On Wed, 2023-09-06 at 13:35 +0200, Maxime Ripard wrote: > Hi Sarah, > > On Wed, Sep 06, 2023 at 10:55:24AM +0100, Sarah Walker wrote: > > From: Donald Robson <donald.robson@xxxxxxxxxx> > > > > Signed-off-by: Donald Robson <donald.robson@xxxxxxxxxx> > > Sorry, this applied to your previous versions too but I only caught it > right now. When you submit a patch on someone else's behalf, you need to > add your Signed-off-by. That's also true when you're the committer of a > patch you didn't write. > > This one, and patch 1, are affected. > > Also, generally speaking, it's a good to write a commit log for a patch > to at least provide some context on what you want to achieve. Sorry for this, will get these issues addressed before the next patchset. Sarah