On 5.09.2023 18:19, Krzysztof Kozlowski wrote: > The Qualcomm UFS phy switched from dedicated driver to QMP phy driver. > Eventually the old driver was removed in commit 02dca8c981b5 ("phy: > qcom: remove ufs qmp phy driver"). The original driver and its binding > used vddp-ref-clk regulator supply, but the new one did not and left the > supply unused. > > The Qualcomm UFS phy bindings were also migrated to newer ones and > dropped support for vddp-ref-clk regulator in commit dc5cb63592bd > ("dt-bindings: phy: migrate QMP UFS PHY bindings to > qcom,sc8280xp-qmp-ufs-phy.yaml"). > > It turns out that this regulator, although with inaccurate name > vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or > similar, depending on the SoC) used by UFS controller. > > Bring back handling of this supply by using more appropriate regulator - > UFS controller host supply. This also fixes dtbs_check warning: > > sm6115p-lenovo-j606f.dtb: phy@4807000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad