On 06/09/2023 10:32, Laurent Pinchart wrote: > Hi Krzysztof, > > On Wed, Sep 06, 2023 at 09:27:07AM +0200, Krzysztof Kozlowski wrote: >> On 06/09/2023 01:31, Paul Elder wrote: >>> Add overlays for the Pumpkin i350 to support THP7312 cameras. >>> >>> Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx> >>> --- >>> arch/arm64/boot/dts/mediatek/Makefile | 4 + >>> .../mt8365-pumpkin-common-thp7312.dtsi | 23 ++++++ >>> .../mt8365-pumpkin-csi0-thp7312-imx258.dtso | 73 +++++++++++++++++++ >>> .../mt8365-pumpkin-csi1-thp7312-imx258.dtso | 73 +++++++++++++++++++ >>> 4 files changed, 173 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi >>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi0-thp7312-imx258.dtso >>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi1-thp7312-imx258.dtso >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile >>> index 20570bc40de8..ceaf24105001 100644 >>> --- a/arch/arm64/boot/dts/mediatek/Makefile >>> +++ b/arch/arm64/boot/dts/mediatek/Makefile >>> @@ -56,4 +56,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-evk.dtb >>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-pumpkin.dtb >>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb >>> >>> +mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-csi0-thp7312-imx258.dtbo >>> +mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-csi1-thp7312-imx258.dtbo >>> mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-ethernet-usb.dtbo >>> + >>> +dtb-$(CONFIG_ARCH_MEDIATEK) += mtk-mt8365-pumpkin.dtb >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi b/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi >>> new file mode 100644 >>> index 000000000000..478697552617 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi >>> @@ -0,0 +1,23 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Copyright (c) 2023 Ideas on Board >>> + * Author: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx> >>> + */ >>> + >>> +/dts-v1/; >>> +/plugin/; >>> + >>> +&{/} { >>> + vsys_v4p2: regulator@0 { >> >> Hm? Is this a bus? > > There are multiple instances of "numbered" regulators in upstream DT > files, for instance arch/arm/boot/dts/nxp/imx/imx6qdl-nitrogen6_max.dtsi That's the only example I saw... I fixed it now. > has a regulator@0. There are similar instances for clocks. > > I understand why it may not be a good idea, and how the root node is > indeed not a bus. In some cases, those regulators and clocks are grouped > in a regulators or clocks node that has a "simple-bus" compatible. I'm > not sure if that's a good idea, but at least it should validate. > > What's the best practice for discrete board-level clocks and regulators > in overlays ? How do we ensure that their node name will not conflict > with the board to which the overlay is attached ? Top-level nodes (so under /) do not have unit addresses. If they have - it's an error, because it is not a bus. Also, unit address requires reg. No reg? No unit address. DTC reports this as warnings as well. >>> + orientation = <0>; >>> + rotation = <0>; >>> + >>> + thine,rx,data-lanes = <4 1 3 2>; >> >> NAK for this property. > > Please explain why. You commented very briefly in the bindings review, > and it wasn't clear to me if you were happy or not with the property, > and if not, why. Because it is duplicating endpoint. At least from the description. Best regards, Krzysztof