On Sat, Dec 20, 2014 at 11:44:37AM +0100, Hans de Goede wrote: > Hi Dmitry, > > On 18-12-14 18:51, Dmitry Torokhov wrote: > >Hi Hans, > > > >On Thu, Dec 18, 2014 at 11:23:13AM +0100, Hans de Goede wrote: > >>Allwinnner sunxi SoCs have a low resolution adc (called lradc) which is > >>specifically designed to have various (tablet) keys (ie home, back, search, > >>etc). attached to it using a resistor network. This adds a driver for this. > >> > >>There are 2 channels, currently this driver only supports chan0 since there > >>are no boards known to use chan1. > >> > >>This has been tested on an olimex a10s-olinuxino-micro, a13-olinuxino, and > >>a20-olinuxino-micro. > >> > >>Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > >>-- > >>Changes in v2: > >>-Change devicetree bindings to use a per key subnode, like gpio-keys does > >>Changes in v3: > >>-Handle keyup irq flag before irqdown, in case we get both at once > > > >Thank you for making changes. Can you please tell me if the driver still > >works if you drop the patch below on top of it? The changes are: > > > >- split DT parsing into a separate function; > >- make sure keymap is not empty; > >- change 'ret' variable to 'error'; > > The proposed changes look good, and I've given them a test-spin and everything > still works fine. Excellent, folded and applied. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
