On Mon, 2023-09-04 at 22:45 +0800, Jisheng Zhang wrote: > On Sun, Sep 03, 2023 at 04:32:21PM -0700, Drew Fustini wrote: > > On Sun, Aug 20, 2023 at 07:53:53PM +0800, Jisheng Zhang wrote: > > > riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't > > > dma coherent, so set dma-noncoherent to reflect this fact. > > > > > > Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx> > > > --- > > > arch/riscv/boot/dts/thead/th1520.dtsi | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi > > > index 56a73134b49e..58108f0eb3fd 100644 > > > --- a/arch/riscv/boot/dts/thead/th1520.dtsi > > > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi > > > @@ -139,6 +139,7 @@ soc { > > > interrupt-parent = <&plic>; > > > #address-cells = <2>; > > > #size-cells = <2>; > > > + dma-noncoherent; > > > ranges; > > > > > > plic: interrupt-controller@ffd8000000 { > > > -- > > > 2.40.1 > > > > > > > Tested-by: Drew Fustini <dfustini@xxxxxxxxxxxx> > > > > I tried this on the BeagleV Ahead. They system booted as expected and I > > did not notice any problems in the boot log. > > > > Are there other patches such as the dwmac series that I should test this > > with? > > Hmm, this patch is necessary to test dwmac, emmc ;) Drew: does this fix the "broken DMA" issue you've mentioned in the EMMC support patch? -- Xi Ruoyao <xry111@xxxxxxxxxxx> School of Aerospace Science and Technology, Xidian University