On 4.09.2023 08:42, Krzysztof Kozlowski wrote: > On 04/09/2023 07:50, Vignesh Viswanathan wrote: >> qcom,ipq6018-tcsr-mutex maps to incorrect config of IPQ6018 and is >> dropped from the devictree. > > No, it is not dropped. > > >> IPQ6018 will use qcom,tcsr-mutex compatible >> string. > > No, it will not. > >> >> Drop qcom,ipq6018-tcsr-mutex compatible string from >> qcom_hwspinlock_of_match table. > > Why? Do not write what you are doing here, but why you are doing it. More importantly, looks like the ipq6018 compatible was added after support for this SoC was introduced (see f5e303aefc06 and 5bf635621245a), so if it's going to use of_tcsr_mutex data with the fallback compat, the SoC-specific compatible can be removed from the driver. Konrad
