On 04/09/2023 06:25, Kwanghoon Son wrote: > This driver supports th1520 T-HEAD SoC reset platform device. > > Signed-off-by: Kwanghoon Son <k.son@xxxxxxxxxxx> > --- > drivers/reset/Kconfig | 10 +++ > drivers/reset/Makefile | 1 + > drivers/reset/reset-th1520.c | 109 +++++++++++++++++++++++ > include/dt-bindings/reset/th1520-reset.h | 9 ++ Bindings are always separate patches. In this case, all bindings should be together. Also you clearly forgot one step: Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof
