On 2.09.2023 19:34, Luca Weiss wrote: > According to a commit in the 3.4 vendor kernel sources[0] the > ocmemcx_ahb_clk clock "is controlled by RPM and should not be touched by > APPS.". > > [0] https://git.codelinaro.org/clo/la/kernel/msm/-/commit/37df5f2d91b4d5768b37fcaacaeea958dd683ebc > > And indeed, when using MDSS+GPU+OCMEM on MSM8226 and not using > clk_ignore_unused, when Linux tries to disable the clock the device > crashes and reboots. > > And since there's also no evidence of this clock in msm8974 vendor > kernel sources, remove the clock for msm8226 and msm8974. Going over the downstream clock driver for 26 and 74 and comparing the registered clocks with mainline may be useful. Older clock drivers were likely written by hand and people doing that likely didn't have a great reference of which clocks should be skipped due to having been moved to firmware somewhere in the bringup process. Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad
