> -----Original Message-----
> From: Rob Herring <robh+dt@xxxxxxxxxx>
> Sent: Tuesday, August 29, 2023 10:14 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx>
> Cc: patrick@xxxxxxxxx; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> Joel Stanley <joel@xxxxxxxxx>; Andrew Jeffery <andrew@xxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-aspeed@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v12 2/2] ARM: dts: aspeed: yosemite4: add Facebook
> Yosemite 4 BMC
>
> Security Reminder: Please be aware that this email is sent by an external
> sender.
>
> On Mon, Aug 28, 2023 at 1:52 AM Delphine CC Chiu
> <Delphine_CC_Chiu@xxxxxxxxxx> wrote:
> >
> > Add linux device tree entry for Yosemite 4 devices connected to BMC.
> > The Yosemite 4 is a Meta multi-node server platform, based on AST2600
> SoC.
>
> This was already applied and sent upstream on Aug 10 by Joel. You'll need
> incremental patches.
I'll rebase the master and generate incremental patches in next time contribution,
thank you for the correction.
>
> >
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>
> > ---
> > Changelog:
> > v12 - Add spi gpio config
> > v11 - Add imux configs for i2c-mux
> > - Add gpio and eeprom devices
> > - Remove temperature-sensor 11-004a and 11-004b
> > - Change power-sensor ina230 to ina233
> > v10 - Change to 128MB flash layout from 64MB
> > v9 - Remove mac2/mac3 duplicated setting about no-hw-checksum
> > v8 - Add description of Yosemite 4
> > - Remove unsupported ncsi config
> > - Revise i2c-mux config
> > - Correct power sensor i2c address
> > - Restore i2c 11 bus-frequency to default
> > v7 - Revise changelog format
> > v6 - Change project name from yosemitev4 to yosemite4
> > v5 - Revise rtc setting
> > - Remove duplicated multi-master setting
> > v3 - Revise the bootargs to stdout-path
> > - Revise i2c devices
> > v2 - Revise the DTS node name
> > ---
> > arch/arm/boot/dts/aspeed/Makefile | 1 +
> > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 1102
> > +++++++++++++++++
> > 2 files changed, 1103 insertions(+)
> > create mode 100644
> > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> >
> > diff --git a/arch/arm/boot/dts/aspeed/Makefile
> > b/arch/arm/boot/dts/aspeed/Makefile
> > index c68984322a86..5b9264b823f3 100644
> > --- a/arch/arm/boot/dts/aspeed/Makefile
> > +++ b/arch/arm/boot/dts/aspeed/Makefile
> > @@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
> > aspeed-bmc-facebook-wedge400.dtb \
> > aspeed-bmc-facebook-yamp.dtb \
> > aspeed-bmc-facebook-yosemitev2.dtb \
> > + aspeed-bmc-facebook-yosemite4.dtb \
> > aspeed-bmc-ibm-bonnell.dtb \
> > aspeed-bmc-ibm-everest.dtb \
> > aspeed-bmc-ibm-rainier.dtb \
> > diff --git
> > a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > new file mode 100644
> > index 000000000000..851091a512dd
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > @@ -0,0 +1,1102 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later // Copyright 2022
> > +Facebook Inc.
> > +
> > +/dts-v1/;
> > +#include "aspeed-g6.dtsi"
> > +#include <dt-bindings/gpio/aspeed-gpio.h> #include
> > +<dt-bindings/leds/leds-pca955x.h>
> > +#include <dt-bindings/i2c/i2c.h>
> > +
> > +/ {
> > + model = "Facebook Yosemite 4 BMC";
> > + compatible = "facebook,yosemite4-bmc", "aspeed,ast2600";
> > +
> > + aliases {
> > + serial4 = &uart5;
> > + serial5 = &uart6;
> > + serial6 = &uart7;
> > + serial7 = &uart8;
> > + serial8 = &uart9;
> > +
> > + i2c16 = &imux16;
> > + i2c17 = &imux17;
> > + i2c18 = &imux18;
> > + i2c19 = &imux19;
> > + i2c20 = &imux20;
> > + i2c21 = &imux21;
> > + i2c22 = &imux22;
> > + i2c23 = &imux23;
> > + i2c24 = &imux24;
> > + i2c25 = &imux25;
> > + i2c26 = &imux26;
> > + i2c27 = &imux27;
> > + i2c28 = &imux28;
> > + i2c29 = &imux29;
> > + i2c30 = &imux30;
> > + i2c31 = &imux31;
> > + i2c32 = &imux32;
> > + i2c33 = &imux33;
> > + };
> > +
> > + chosen {
> > + stdout-path = "serial4:57600n8";
> > + };
> > +
> > + memory@80000000 {
> > + device_type = "memory";
> > + reg = <0x80000000 0x80000000>;
> > + };
> > +
> > + iio-hwmon {
> > + compatible = "iio-hwmon";
> > + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>,
> <&adc0 3>,
> > + <&adc0 4>, <&adc0 5>, <&adc0 6>,
> <&adc0 7>,
> > + <&adc1 0>, <&adc1 1>;
> > + };
> > +
> > + spi_gpio: spi-gpio {
> > + status = "okay";
> > + compatible = "spi-gpio";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + gpio-sck = <&gpio0 ASPEED_GPIO(X, 3)
> GPIO_ACTIVE_HIGH>;
> > + gpio-mosi = <&gpio0 ASPEED_GPIO(X, 4)
> GPIO_ACTIVE_HIGH>;
> > + gpio-miso = <&gpio0 ASPEED_GPIO(X, 5)
> GPIO_ACTIVE_HIGH>;
> > + num-chipselects = <1>;
> > + cs-gpios = <&gpio0 ASPEED_GPIO(X, 0)
> GPIO_ACTIVE_LOW>;
> > +
> > + tpmdev@0 {
> > + compatible = "tcg,tpm_tis-spi";
> > + spi-max-frequency = <33000000>;
> > + reg = <0>;
> > + };
> > + };
> > +};
> > +
> > +&uart1 {
> > + status = "okay";
> > +};
> > +
> > +&uart2 {
> > + status = "okay";
> > +};
> > +
> > +&uart3 {
> > + status = "okay";
> > +};
> > +
> > +&uart4 {
> > + status = "okay";
> > +};
> > +
> > +&uart5 {
> > + status = "okay";
> > +};
> > +
> > +&uart6 {
> > + status = "okay";
> > +};
> > +
> > +&uart7 {
> > + status = "okay";
> > +};
> > +
> > +&uart8 {
> > + status = "okay";
> > +};
> > +
> > +&uart9 {
> > + status = "okay";
> > +};
> > +
> > +&wdt1 {
> > + status = "okay";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_wdtrst1_default>;
> > + aspeed,reset-type = "soc";
> > + aspeed,external-signal;
> > + aspeed,ext-push-pull;
> > + aspeed,ext-active-high;
> > + aspeed,ext-pulse-duration = <256>; };
> > +
> > +&mac2 {
> > + status = "okay";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_rmii3_default>;
> > + use-ncsi;
> > + mlx,multi-host;
> > +};
> > +
> > +&mac3 {
> > + status = "okay";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_rmii4_default>;
> > + use-ncsi;
> > + mlx,multi-host;
> > +};
> > +
> > +&fmc {
> > + status = "okay";
> > + flash@0 {
> > + status = "okay";
> > + m25p,fast-read;
> > + label = "bmc";
> > + spi-rx-bus-width = <4>;
> > + spi-max-frequency = <50000000>; #include
> > +"openbmc-flash-layout-128.dtsi"
> > + };
> > + flash@1 {
> > + status = "okay";
> > + m25p,fast-read;
> > + label = "bmc2";
> > + spi-rx-bus-width = <4>;
> > + spi-max-frequency = <50000000>;
> > + };
> > +};
> > +
> > +&i2c0 {
> > + status = "okay";
> > + mctp-controller;
> > + bus-frequency = <400000>;
> > + multi-master;
> > +
> > + mctp@10 {
> > + compatible = "mctp-i2c-controller";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + };
> > +
> > + power-sensor@40 {
> > + compatible = "adi,adm1278";
> > + reg = <0x40>;
> > + };
> > +};
> > +
> > +&i2c1 {
> > + status = "okay";
> > + mctp-controller;
> > + bus-frequency = <400000>;
> > + multi-master;
> > +
> > + mctp@10 {
> > + compatible = "mctp-i2c-controller";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + };
> > +
> > + power-sensor@40 {
> > + compatible = "adi,adm1278";
> > + reg = <0x40>;
> > + };
> > +};
> > +
> > +&i2c2 {
> > + status = "okay";
> > + mctp-controller;
> > + bus-frequency = <400000>;
> > + multi-master;
> > +
> > + mctp@10 {
> > + compatible = "mctp-i2c-controller";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + };
> > +
> > + power-sensor@40 {
> > + compatible = "adi,adm1278";
> > + reg = <0x40>;
> > + };
> > +};
> > +
> > +&i2c3 {
> > + status = "okay";
> > + mctp-controller;
> > + bus-frequency = <400000>;
> > + multi-master;
> > +
> > + mctp@10 {
> > + compatible = "mctp-i2c-controller";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + };
> > +
> > + power-sensor@40 {
> > + compatible = "adi,adm1278";
> > + reg = <0x40>;
> > + };
> > +};
> > +
> > +&i2c4 {
> > + status = "okay";
> > + mctp-controller;
> > + bus-frequency = <400000>;
> > + multi-master;
> > +
> > + mctp@10 {
> > + compatible = "mctp-i2c-controller";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + };
> > +
> > + power-sensor@40 {
> > + compatible = "adi,adm1278";
> > + reg = <0x40>;
> > + };
> > +};
> > +
> > +&i2c5 {
> > + status = "okay";
> > + mctp-controller;
> > + bus-frequency = <400000>;
> > + multi-master;
> > +
> > + mctp@10 {
> > + compatible = "mctp-i2c-controller";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + };
> > +
> > + power-sensor@40 {
> > + compatible = "adi,adm1278";
> > + reg = <0x40>;
> > + };
> > +};
> > +
> > +&i2c6 {
> > + status = "okay";
> > + mctp-controller;
> > + bus-frequency = <400000>;
> > + multi-master;
> > +
> > + mctp@10 {
> > + compatible = "mctp-i2c-controller";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + };
> > +
> > + power-sensor@40 {
> > + compatible = "adi,adm1278";
> > + reg = <0x40>;
> > + };
> > +};
> > +
> > +&i2c7 {
> > + status = "okay";
> > + mctp-controller;
> > + bus-frequency = <400000>;
> > + multi-master;
> > +
> > + mctp@10 {
> > + compatible = "mctp-i2c-controller";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + };
> > +
> > + power-sensor@40 {
> > + compatible = "adi,adm1278";
> > + reg = <0x40>;
> > + };
> > +};
> > +
> > +&i2c8 {
> > + status = "okay";
> > + bus-frequency = <400000>;
> > + i2c-mux@70 {
> > + compatible = "nxp,pca9544";
> > + idle-state = <0>;
> > + i2c-mux-idle-disconnect;
> > + reg = <0x70>;
> > +
> > + imux16: i2c@0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0>;
> > + gpio@20 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x20>;
> > + };
> > +
> > + gpio@21 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x21>;
> > + };
> > +
> > + gpio@22 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x22>;
> > + };
> > +
> > + gpio@23 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x23>;
> > + };
> > +
> > + gpio@49 {
> > + compatible = "nxp,pca9537";
> > + reg = <0x49>;
> > + };
> > +
> > + eeprom@50 {
> > + compatible = "atmel,24c128";
> > + reg = <0x50>;
> > + };
> > +
> > + eeprom@51 {
> > + compatible = "atmel,24c128";
> > + reg = <0x51>;
> > + };
> > +
> > + eeprom@54 {
> > + compatible = "atmel,24c128";
> > + reg = <0x54>;
> > + };
> > + };
> > +
> > + imux17: i2c@1 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <1>;
> > + gpio@20 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x20>;
> > + };
> > +
> > + gpio@21 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x21>;
> > + };
> > +
> > + gpio@22 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x22>;
> > + };
> > +
> > + gpio@23 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x23>;
> > + };
> > +
> > + gpio@49 {
> > + compatible = "nxp,pca9537";
> > + reg = <0x49>;
> > + };
> > +
> > + eeprom@50 {
> > + compatible = "atmel,24c128";
> > + reg = <0x50>;
> > + };
> > +
> > + eeprom@51 {
> > + compatible = "atmel,24c128";
> > + reg = <0x51>;
> > + };
> > +
> > + eeprom@54 {
> > + compatible = "atmel,24c128";
> > + reg = <0x54>;
> > + };
> > + };
> > +
> > + imux18: i2c@2 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <2>;
> > + gpio@20 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x20>;
> > + };
> > +
> > + gpio@21 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x21>;
> > + };
> > +
> > + gpio@22 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x22>;
> > + };
> > +
> > + gpio@23 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x23>;
> > + };
> > +
> > + gpio@49 {
> > + compatible = "nxp,pca9537";
> > + reg = <0x49>;
> > + };
> > +
> > + eeprom@50 {
> > + compatible = "atmel,24c128";
> > + reg = <0x50>;
> > + };
> > +
> > + eeprom@51 {
> > + compatible = "atmel,24c128";
> > + reg = <0x51>;
> > + };
> > +
> > + eeprom@54 {
> > + compatible = "atmel,24c128";
> > + reg = <0x54>;
> > + };
> > + };
> > +
> > + imux19: i2c@3 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <3>;
> > + gpio@20 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x20>;
> > + };
> > +
> > + gpio@21 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x21>;
> > + };
> > +
> > + gpio@22 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x22>;
> > + };
> > +
> > + gpio@23 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x23>;
> > + };
> > +
> > + gpio@49 {
> > + compatible = "nxp,pca9537";
> > + reg = <0x49>;
> > + };
> > +
> > + eeprom@50 {
> > + compatible = "atmel,24c128";
> > + reg = <0x50>;
> > + };
> > +
> > + eeprom@51 {
> > + compatible = "atmel,24c128";
> > + reg = <0x51>;
> > + };
> > +
> > + eeprom@54 {
> > + compatible = "atmel,24c128";
> > + reg = <0x54>;
> > + };
> > + };
> > + };
> > +};
> > +
> > +&i2c9 {
> > + status = "okay";
> > + bus-frequency = <400000>;
> > + i2c-mux@71 {
> > + compatible = "nxp,pca9544";
> > + idle-state = <0>;
> > + i2c-mux-idle-disconnect;
> > + reg = <0x71>;
> > +
> > + imux20: i2c@0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0>;
> > + gpio@20 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x20>;
> > + };
> > +
> > + gpio@21 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x21>;
> > + };
> > +
> > + gpio@22 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x22>;
> > + };
> > +
> > + gpio@23 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x23>;
> > + };
> > +
> > + gpio@49 {
> > + compatible = "nxp,pca9537";
> > + reg = <0x49>;
> > + };
> > +
> > + eeprom@50 {
> > + compatible = "atmel,24c128";
> > + reg = <0x50>;
> > + };
> > +
> > + eeprom@51 {
> > + compatible = "atmel,24c128";
> > + reg = <0x51>;
> > + };
> > +
> > + eeprom@54 {
> > + compatible = "atmel,24c128";
> > + reg = <0x54>;
> > + };
> > + };
> > +
> > + imux21: i2c@1 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <1>;
> > + gpio@20 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x20>;
> > + };
> > +
> > + gpio@21 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x21>;
> > + };
> > +
> > + gpio@22 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x22>;
> > + };
> > +
> > + gpio@23 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x23>;
> > + };
> > +
> > + gpio@49 {
> > + compatible = "nxp,pca9537";
> > + reg = <0x49>;
> > + };
> > +
> > + eeprom@50 {
> > + compatible = "atmel,24c128";
> > + reg = <0x50>;
> > + };
> > +
> > + eeprom@51 {
> > + compatible = "atmel,24c128";
> > + reg = <0x51>;
> > + };
> > +
> > + eeprom@54 {
> > + compatible = "atmel,24c128";
> > + reg = <0x54>;
> > + };
> > + };
> > +
> > + imux22: i2c@2 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <2>;
> > + gpio@20 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x20>;
> > + };
> > +
> > + gpio@21 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x21>;
> > + };
> > +
> > + gpio@22 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x22>;
> > + };
> > +
> > + gpio@23 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x23>;
> > + };
> > +
> > + gpio@49 {
> > + compatible = "nxp,pca9537";
> > + reg = <0x49>;
> > + };
> > +
> > + eeprom@50 {
> > + compatible = "atmel,24c128";
> > + reg = <0x50>;
> > + };
> > +
> > + eeprom@51 {
> > + compatible = "atmel,24c128";
> > + reg = <0x51>;
> > + };
> > +
> > + eeprom@54 {
> > + compatible = "atmel,24c128";
> > + reg = <0x54>;
> > + };
> > + };
> > +
> > + imux23: i2c@3 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <3>;
> > + gpio@20 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x20>;
> > + };
> > +
> > + gpio@21 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x21>;
> > + };
> > +
> > + gpio@22 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x22>;
> > + };
> > +
> > + gpio@23 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x23>;
> > + };
> > +
> > + gpio@49 {
> > + compatible = "nxp,pca9537";
> > + reg = <0x49>;
> > + };
> > +
> > + eeprom@50 {
> > + compatible = "atmel,24c128";
> > + reg = <0x50>;
> > + };
> > +
> > + eeprom@51 {
> > + compatible = "atmel,24c128";
> > + reg = <0x51>;
> > + };
> > +
> > + eeprom@54 {
> > + compatible = "atmel,24c128";
> > + reg = <0x54>;
> > + };
> > + };
> > + };
> > +};
> > +
> > +&i2c10 {
> > + status = "okay";
> > + bus-frequency = <400000>;
> > + i2c-mux@74 {
> > + compatible = "nxp,pca9544";
> > + idle-state = <0>;
> > + i2c-mux-idle-disconnect;
> > + reg = <0x74>;
> > +
> > + imux28: i2c@0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0>;
> > + };
> > +
> > + imux29: i2c@1 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <1>;
> > + gpio@20 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x20>;
> > + };
> > +
> > + gpio@21 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x21>;
> > + };
> > +
> > + gpio@22 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x22>;
> > + };
> > +
> > + gpio@23 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x23>;
> > + };
> > +
> > + gpio@24 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x24>;
> > + };
> > + };
> > + };
> > +};
> > +
> > +&i2c11 {
> > + status = "okay";
> > + power-sensor@10 {
> > + compatible = "adi, adm1272";
> > + reg = <0x10>;
> > + };
> > +
> > + power-sensor@12 {
> > + compatible = "adi, adm1272";
> > + reg = <0x12>;
> > + };
> > +
> > + gpio@20 {
> > + compatible = "nxp,pca9555";
> > + reg = <0x20>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + };
> > +
> > + gpio@21 {
> > + compatible = "nxp,pca9555";
> > + reg = <0x21>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + };
> > +
> > + gpio@22 {
> > + compatible = "nxp,pca9555";
> > + reg = <0x22>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + };
> > +
> > + gpio@23 {
> > + compatible = "nxp,pca9555";
> > + reg = <0x23>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + };
> > +
> > + temperature-sensor@48 {
> > + compatible = "ti,tmp75";
> > + reg = <0x48>;
> > + };
> > +
> > + temperature-sensor@49 {
> > + compatible = "ti,tmp75";
> > + reg = <0x49>;
> > + };
> > +
> > + eeprom@54 {
> > + compatible = "atmel,24c256";
> > + reg = <0x54>;
> > + };
> > +};
> > +
> > +&i2c12 {
> > + status = "okay";
> > + bus-frequency = <400000>;
> > +
> > + temperature-sensor@48 {
> > + compatible = "ti,tmp75";
> > + reg = <0x48>;
> > + };
> > +
> > + eeprom@50 {
> > + compatible = "atmel,24c128";
> > + reg = <0x50>;
> > + };
> > +
> > + eeprom@54 {
> > + compatible = "atmel,24c64";
> > + reg = <0x54>;
> > + };
> > +
> > + rtc@6f {
> > + compatible = "nuvoton,nct3018y";
> > + reg = <0x6f>;
> > + };
> > +};
> > +
> > +&i2c13 {
> > + status = "okay";
> > + bus-frequency = <400000>;
> > + gpio@20 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x20>;
> > + };
> > +
> > + gpio@21 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x21>;
> > + };
> > +
> > + gpio@22 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x22>;
> > + };
> > +
> > + gpio@23 {
> > + compatible = "nxp,pca9506";
> > + reg = <0x23>;
> > + };
> > +};
> > +
> > +&i2c14 {
> > + status = "okay";
> > + bus-frequency = <400000>;
> > + adc@1d {
> > + compatible = "ti,adc128d818";
> > + reg = <0x1d>;
> > + ti,mode = /bits/ 8 <2>;
> > + };
> > +
> > + adc@35 {
> > + compatible = "ti,adc128d818";
> > + reg = <0x35>;
> > + ti,mode = /bits/ 8 <2>;
> > + };
> > +
> > + adc@37 {
> > + compatible = "ti,adc128d818";
> > + reg = <0x37>;
> > + ti,mode = /bits/ 8 <2>;
> > + };
> > +
> > + power-sensor@40 {
> > + compatible = "ti,ina233";
> > + reg = <0x40>;
> > + };
> > +
> > + power-sensor@41 {
> > + compatible = "ti,ina233";
> > + reg = <0x41>;
> > + };
> > +
> > + power-sensor@42 {
> > + compatible = "ti,ina233";
> > + reg = <0x42>;
> > + };
> > +
> > + power-sensor@43 {
> > + compatible = "ti,ina233";
> > + reg = <0x43>;
> > + };
> > +
> > + power-sensor@44 {
> > + compatible = "ti,ina233";
> > + reg = <0x44>;
> > + };
> > +
> > + temperature-sensor@4e {
> > + compatible = "ti,tmp75";
> > + reg = <0x4e>;
> > + };
> > +
> > + temperature-sensor@4f {
> > + compatible = "ti,tmp75";
> > + reg = <0x4f>;
> > + };
> > +
> > + eeprom@51 {
> > + compatible = "atmel,24c128";
> > + reg = <0x51>;
> > + };
> > +
> > + i2c-mux@71 {
> > + compatible = "nxp,pca9846";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + idle-state = <0>;
> > + i2c-mux-idle-disconnect;
> > + reg = <0x71>;
> > +
> > + imux30: i2c@0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0>;
> > +
> > + adc@1f {
> > + compatible = "ti,adc128d818";
> > + reg = <0x1f>;
> > + ti,mode = /bits/ 8 <2>;
> > + };
> > +
> > + pwm@20{
> > + compatible = "max31790";
>
> This is not documented. It also needs a vendor prefix.
The vendor prefix will be added in next time contribution,
and this device seems has been used in former projects.
Would you please to tell that whether I should inform the driver's author or add the binding document on my own ?
>
> > + reg = <0x20>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> These 2 are for child nodes, but you don't have any. And a PWM probably
> never will.
I'll remove the redundant config in next time contribution,
thank you for the correction.
>
> Rob
