On Fri, 24 Mar 2023 at 22:23, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > 'clocks' node is not a bus, but just a placeholder for clocks: > > apq8096-db820c.dtb: clocks: $nodename:0: 'clocks' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$' > From schema: dtschema/schemas/simple-bus.yaml > apq8096-db820c.dtb: clocks: xo-board: {'compatible': ['fixed-clock'], '#clock-cells': [[0]], ... > From schema: dtschema/schemas/simple-bus.yaml > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> This patch broke audio support on DB820c. Now the divclk1 clock is not registered, as drivers/clk/clk-gpio.c doesn't have CLK_OF_DECLARE(). Stephen, What would be the best way to fix this? Add CLK_OF_DECLARE support to clk-gpio.c? Or simply move divclk1 from /clocks into a separate device? What is the rule, which clock drivers must support such device-less binding using /clocks/foo nodes? > --- > arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts > index 4476e2e22816..b599909c4463 100644 > --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts > +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts > @@ -63,7 +63,6 @@ chosen { > }; > > clocks { > - compatible = "simple-bus"; > divclk4: divclk4 { > compatible = "fixed-clock"; > #clock-cells = <0>; > -- > 2.34.1 > -- With best wishes Dmitry