On Sat, Aug 26, 2023 at 9:32 PM Adam Ford <aford173@xxxxxxxxx> wrote: > > The i.MX8MP has a micfil controller which is used for interfacing > with a pulse density microphone. Add the node and mark it as > disabled by default. > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx> > --- Nak. I guess I'll Nak myself. > V2: No Change > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 79cdd4c066c8..b44851a2f579 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1473,6 +1473,27 @@ easrc: easrc@30c90000 { > fsl,asrc-format = <2>; > status = "disabled"; > }; > + > + micfil: audio-controller@30ca0000 { > + compatible = "fsl,imx8mp-micfil"; > + reg = <0x30ca0000 0x10000>; > + #sound-dai-cells = <0>; > + interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_PDM_IPG>, > + <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_PDM_ROOT>, After a bunch of attempts to get this working on real hardware, it turns out that IMX8MP_CLK_AUDIOMIX_PDM_ROOT doesn't really exist. Its real name is IMX8MP_CLK_AUDIOMIX_PDM_SEL. I'll submit a patch to remove this from imx8mp-clock.h and and a V3 of this series to update the clock reference in this node. > + <&clk IMX8MP_AUDIO_PLL1_OUT>, > + <&clk IMX8MP_AUDIO_PLL2_OUT>, > + <&clk IMX8MP_CLK_EXT3>; > + clock-names = "ipg_clk", "ipg_clk_app", > + "pll8k", "pll11k", "clkext3"; > + dmas = <&sdma2 24 25 0x80000000>; > + dma-names = "rx"; > + status = "disabled"; > + }; > + > }; > > sdma3: dma-controller@30e00000 { > -- > 2.39.2 >