On 30/08/2023 13:37, Rafael J. Wysocki wrote: > On Tue, Aug 29, 2023 at 9:42 PM Fabio Estevam <festevam@xxxxxxxxx> wrote: >> >> From: Fabio Estevam <festevam@xxxxxxx> >> >> Document the critical-action property to describe the thermal action >> the OS should perform after the critical temperature is reached. >> >> The possible values are "shutdown" and "reboot". >> >> The motivation for introducing the critical-action property is that >> different systems may need different thermal actions when the critical >> temperature is reached. >> >> For example, a desktop PC may want the OS to trigger a shutdown >> when the critical temperature is reached. >> >> However, in some embedded cases, such behavior does not suit well, >> as the board may be unattended in the field and rebooting may be a >> better approach. >> >> The bootloader may also benefit from this new property as it can check >> the SoC temperature and in case the temperature is above the critical >> point, it can trigger a shutdown or reboot accordingly. >> >> Signed-off-by: Fabio Estevam <festevam@xxxxxxx> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> --- >> Changes since v4: >> - None. >> >> .../devicetree/bindings/thermal/thermal-zones.yaml | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml >> index 4f3acdc4dec0..c2e4d28f885b 100644 >> --- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml >> +++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml >> @@ -75,6 +75,15 @@ patternProperties: >> framework and assumes that the thermal sensors in this zone >> support interrupts. >> >> + critical-action: >> + $ref: /schemas/types.yaml#/definitions/string >> + description: >> + The action the OS should perform after the critical temperature is reached. >> + >> + enum: >> + - shutdown >> + - reboot >> + >> thermal-sensors: >> $ref: /schemas/types.yaml#/definitions/phandle-array >> maxItems: 1 >> -- > > I'm wondering if this should be a bool property called > "critical-reboot", say, which when present would mean to carry out a > reboot instead of a shutdown in an emergency. > > As defined above, the "shutdown" value is simply redundant, because > the code will effectively convert any other value to "shutdown" > anyway. We covered this at v1. Bool does not allow this property to change in the future, e.g. for a third mode. And how would you change the action to shutdown if default action in the system was reboot? Best regards, Krzysztof
