Re: [PATCH V2 0/4] hwmon: ina3221: Add selective summation support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/29/23 05:52, Jon Hunter wrote:

On 25/08/2023 18:11, Guenter Roeck wrote:
On Sat, Aug 26, 2023 at 12:42:45AM +0800, Ninad Malwade wrote:
The current INA3221 driver always sums the shunt voltage for all enabled
channels regardless of the shunt-resistor used for each channel. Summing
the shunt-voltage for channels is only meaningful if the shunt resistor
is the same for each channel. This series adds device-tree support to
allow which channels are summed in device-tree.


V2, but no change log. I am not going to review this series.

Sorry about that the changelog is ...

Changes since V1:
- Added patch to convert dt-binding to json
- Added patch to add new dt property for bypassing/disabling summation
   support for a channel
- Added patch to populate ina3221 devices for Tegra234 boards
- Updated summation bypass patch to display summation status via sysfs


I have not looked at the patches, but this non-standard sysfs attribute
is a no-go. Use debugfs if you want such information to be available.

Guenter




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux