Re: [PATCH v4 2/2] iio: adc: adding support for MCP3564 ADC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 29 Aug 2023 07:29:57 +0000
<Marius.Cristea@xxxxxxxxxxxxx> wrote:

> Hi Jonathan,
> 
>    Thank you for the review.
> 
> 
> > 
> >   
> > > +
> > > +/*
> > > + * Current Source/Sink Selection Bits for Sensor Bias (source on
> > > VIN+/sink on VIN-)
> > > + */
> > > +static const int mcp3564_burnout_avail[][2] = {
> > > +     [MCP3564_CONFIG0_CS_SEL_0_0_uA] = {0, 0},
> > > +     [MCP3564_CONFIG0_CS_SEL_0_9_uA] = {0, 900},
> > > +     [MCP3564_CONFIG0_CS_SEL_3_7_uA] = {0, 3700},
> > > +     [MCP3564_CONFIG0_CS_SEL_15_uA] = {0, 15000}
	[MCP3564_CONFIG0_CS_SEL_15_uA] = { 0, 15000 }

etc

> > > +};  
> > 
> > Trivial, but I'd like brackets after the { and before the } as makes
> > things a tiny bit
> > more readable to my eye.
> > 
> >   
> 
> I'm not sure that I understood what/how to change here. Can you,
> please, give me an example?
> 
> 
> 
> Thanks,
> Marius




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux