Re: [PATCH v4 2/3] dt-bindings: usb: snps,dwc3: Add runtime-suspend-on-usb-suspend property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 8/26/2023 1:39 AM, Krzysztof Kozlowski wrote:
On 26/08/2023 03:53, Thinh Nguyen wrote:
For example on Qualcomm platforms there is a phy sideband signalling
which detects the wakeup signal when resume is initiated by the host.

So compatible-specific.

Thus qcom platforms can benefit from this feature by defining this dt
property. (in a parallel discussion with Thinh N to come up with a
better name for this dt entry).

Thanks, with quite a long message you at the end admitted this is
compatible-specific. Exactly what I wrote it one sentence previously.


Various dwc3 platforms often share a common capability that can be
shared with a common dt property. If we dedicate a property such as in
this case, it helps designers enable a certain feature without updating
the driver every time a new platform is introduced. It also helps keep
the driver a bit simpler on the compatible checks.

That's not the purpose of bindings. Sorry.


Regardless, what Krzysztof said is valid. Perhaps we can look into
enhancing dwc3 to maintain shared behavior based on compatible instead?


Thank you Krzysztof, Thinh, Roger for your comments and feedback. I will upload v5 making this change compatible-specifc.

Best Regards
Elson





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux