On 28/08/2023 14:38, Binbin Zhou wrote:
> The reboot and poweroff features are actually part of the Power
> Management Unit system controller, thus allow them as its children,
> instead of specifying as separate device nodes with syscon phandle.
>
> required:
> - compatible
> - reg
> @@ -44,10 +56,25 @@ examples:
> - |
> #include <dt-bindings/interrupt-controller/irq.h>
>
> - power-management@1fe27000 {
> + pmc: power-management@1fe27000 {
Drop the label.
> compatible = "loongson,ls2k1000-pmc", "syscon";
> reg = <0x1fe27000 0x58>;
> interrupt-parent = <&liointc1>;
> interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> loongson,suspend-address = <0x0 0x1c000500>;
> +
> + syscon-reboot {
> + compatible ="syscon-reboot";
> + regmap = <&pmc>;
No, why? It does not make much sense and is deprecated.
> + offset = <0x30>;
> + mask = <0x1>;
> + };
> +
> + syscon-poweroff {
> + compatible ="syscon-poweroff";
Missing space.
Best regards,
Krzysztof
