On Wed, 16 Aug 2023 15:44:55 +0100 Conor Dooley <conor@xxxxxxxxxx> wrote: > On Wed, Aug 16, 2023 at 04:02:24PM +0800, Mingjin Yang wrote: > > Add ump518 pmic adc description and sample in dt-bindings. ADC Description? I'm seeing the compatible only which doesn't seem like a description to me. > > > > Signed-off-by: Mingjin Yang <mingjin.yang@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml | 2 ++ > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Thanks, > Conor. > > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > > index 8181cf9a8e07..f28d188d83da 100644 > > --- a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > > +++ b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > > @@ -21,6 +21,7 @@ properties: > > - sprd,sc2730-adc > > - sprd,sc2731-adc > > - sprd,ump9620-adc > > + - sprd,ump518-adc alpha-numeric ordering probably worth retaining. So I'd move this and the case below up one line. Thanks, Jonathan > > > > reg: > > maxItems: 1 > > @@ -46,6 +47,7 @@ allOf: > > contains: > > enum: > > - sprd,ump9620-adc > > + - sprd,ump518-adc > > then: > > properties: > > nvmem-cells: > > -- > > 2.17.1 > >