On 8/28/2023 3:16 PM, Krzysztof Kozlowski wrote: > On 28/08/2023 09:12, Hal Feng wrote: >> On Fri, 25 Aug 2023 16:06:12 +0100, Conor Dooley wrote: >>> On Fri, Aug 25, 2023 at 04:13:24PM +0800, William Qiu wrote: >>>> Hi, >>>> >>>> This patchset adds initial rudimentary support for the StarFive >>>> Pulse Width Modulation controller driver. And this driver will >>>> be used in StarFive's VisionFive 2 board.The first patch add >>>> Documentations for the device and Patch 2 adds device probe for >>>> the module. >>>> >>>> Changes v3->v4: >>>> - Rebased to v6.5rc7. >>>> - Sorted the header files in alphabetic order. >>>> - Changed iowrite32() to writel(). >>>> - Added a way to turn off. >>>> - Moified polarity inversion implementation. >>>> - Added 7100 support. >>>> - Added dts patches. >>>> - Used the various helpers in linux/math.h. >>>> - Corrected formatting problems. >>>> - Renamed dtbinding to 'starfive,jh7100-pwm.yaml'. >>>> - Dropped the redundant code. >>>> >>>> Changes v2->v3: >>>> - Fixed some formatting issues. >>>> >>>> Changes v1->v2: >>>> - Renamed the dt-binding 'pwm-starfive.yaml' to 'starfive,jh7110-pwm.yaml'. >>>> - Dropped the compatible's Items. >>>> - Dropped the unuse defines. >>>> - Modified the code to follow the Linux coding style. >>>> - Changed return value to dev_err_probe. >>>> - Dropped the unnecessary local variable. >>>> >>>> The patch series is based on v6.5rc7. >>> >>> Out of curiosity, why is this series still an RFC? >> >> There was no comments received in v4. So William resend it and >> request for comments. > > The question was: why he requests for comments? > > RFC means *it should not be merged, it is not ready*. Oh, it was misunderstood by William and me. So this series is not a RFC. Best regards, Hal