On 26.08.2023 15:43, Dmitry Baryshkov wrote: > On Sat, 26 Aug 2023 at 15:08, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: >> >> On 22.08.2023 02:13, Dmitry Baryshkov wrote: >>> The PMIC is not a part of the SoC, so move PMIC to a separate file and >>> include it from the board files. >>> >>> Suggested-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >>> Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> >>> --- >> [...] >> >>> + pmic { >> Are you leaving an empty subnode here? > > No. It contains 'interrupts' property (which is specific to the SoC). Meh, that's bad design.. should have been in the controller node! But noboyd thought about this 10y+ ago so here we are Acked-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad