On 25/08/2023 17:53, Liam Beguin wrote: > Hi Krzysztof, > > On Fri, Aug 25, 2023 at 08:15:57AM +0200, Krzysztof Kozlowski wrote: >> On 24/08/2023 20:50, Liam Beguin wrote: >>> On Thu, Aug 24, 2023 at 07:56:29PM +0200, Krzysztof Kozlowski wrote: >>>> On 24/08/2023 18:55, Liam Beguin wrote: >>>>> Add devicetree bindings for the Linear Technology LTC2309 ADC driver. >>>>> >>>>> Signed-off-by: Liam Beguin <liambeguin@xxxxxxxxx> >>>> >>>> Thank you for your patch. There is something to discuss/improve. >>>> >>>>> +++ b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2309.yaml >>>>> @@ -0,0 +1,52 @@ >>>>> +# SPDX-License-Identifier: GPL-2.0 >>>> >>>> Wrong license. Run checkpatch before sending patches. >>>> >>> >>> Sorry about that, I ran it through checkpatch but it didn't flag >>> anything. >> >> No, you didn't, because checkpatch flags it easily: >> >> WARNING: DT binding documents should be licensed (GPL-2.0-only OR >> BSD-2-Clause) >> #21: FILE: Documentation/devicetree/bindings/iio/adc/lltc,ltc2309.yaml:1: >> +# SPDX-License-Identifier: GPL-2.0 >> >> total: 0 errors, 2 warnings, 52 lines checked > > It seems like I wasn't running checkpatch in strict mode. No. This was not a strict mode but a regular run. I don't understand why you are turning this all the time around... You can easily check by yourself and reproduce the warning any time. Best regards, Krzysztof
