On Thu 24 Aug 2023 14:44:36 GMT, Guru Das Srinagesh wrote:
[...]
> > > The script is quiet by default (only prints errors) and its verbosity
> > > can be adjusted via an optional parameter.
> >
> > IMO, it would be nice to see which addresses are effectively added, e.g.
> > comparable to the output of git send-email. Perhaps somehing like:
> >
> > $ scripts/add-maintainer.py *.patch
> > 0001-fixup-scripts-Add-add-maintainer.py.patch: Adding 'To: Guru Das Srinagesh <quic_gurus@xxxxxxxxxxx>' (maintainer)
> > 0001-fixup-scripts-Add-add-maintainer.py.patch: Adding 'Cc: linux-kernel@xxxxxxxxxxxxxxx' (list)
> >
> > Perhaps verbosity should then be configurable.
>
> Yes, this is already implemented - you just need to pass "--verbosity debug" to
> the script. Example based on commit 8648aeb5d7b7 ("power: supply: add Qualcomm
> PMI8998 SMB2 Charger driver") converted to a patch:
>
> $ ./scripts/add-maintainer.py --verbosity debug $u/upstream/patches/test2/0001-power-supply-add-Qualcomm-PMI8998-SMB2-Charger-drive.patch
> INFO: GET: Patch: 0001-power-supply-add-Qualcomm-PMI8998-SMB2-Charger-drive.patch
> DEBUG:
> Sebastian Reichel <sre@xxxxxxxxxx> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
> Andy Gross <agross@xxxxxxxxxx> (maintainer:ARM/QUALCOMM SUPPORT)
> Bjorn Andersson <andersson@xxxxxxxxxx> (maintainer:ARM/QUALCOMM SUPPORT)
> Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> (maintainer:ARM/QUALCOMM SUPPORT)
> Nathan Chancellor <nathan@xxxxxxxxxx> (supporter:CLANG/LLVM BUILD SUPPORT)
> Nick Desaulniers <ndesaulniers@xxxxxxxxxx> (supporter:CLANG/LLVM BUILD SUPPORT)
> Tom Rix <trix@xxxxxxxxxx> (reviewer:CLANG/LLVM BUILD SUPPORT)
> linux-kernel@xxxxxxxxxxxxxxx (open list)
> linux-pm@xxxxxxxxxxxxxxx (open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
> linux-arm-msm@xxxxxxxxxxxxxxx (open list:ARM/QUALCOMM SUPPORT)
> llvm@xxxxxxxxxxxxxxx (open list:CLANG/LLVM BUILD SUPPORT)
>
> INFO: ADD: Patch: 0001-power-supply-add-Qualcomm-PMI8998-SMB2-Charger-drive.patch
> DEBUG: Cc Lists:
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> Cc: llvm@xxxxxxxxxxxxxxx
> Cc: linux-pm@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> DEBUG: Cc Others:
> Cc: Tom Rix <trix@xxxxxxxxxx>
> Cc: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> Cc: Nathan Chancellor <nathan@xxxxxxxxxx>
> DEBUG: Cc Maintainers:
> None
> DEBUG: To Maintainers:
> To: Sebastian Reichel <sre@xxxxxxxxxx>
> To: Andy Gross <agross@xxxxxxxxxx>
> To: Bjorn Andersson <andersson@xxxxxxxxxx>
> To: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>
> INFO: Maintainers added to all patch files successfully
>
> The first "GET:" output prints the output of `get_maintainer.pl` verbatim, and
> the "ADD:" output shows what exactly is getting added to that patch. Hope this
> is what you were expecting. Please let me know if you'd prefer any other
> modifications to this debug output.
ups. I tested with --verbosity=info but not with =debug, therefore I
missed it. Sorry for the noise.
[...]
> > While testing, I thought that adding addresses without filtering-out duplicates
> > was odd; but as git-send-email does the unique filtering, it doesn't matter.
>
> Since I'm using `set()` in this script, the uniqueness is guaranteed here as
> well - there won't be any duplicates.
I thought about patch files that already have 'To/Cc' headers (e.g.
'git format-patch --to=... --cc=...' or by running add-maintainer.py
multiple times for updating the lists of recipients. The result is a
patch file with possible duplicated lines; but as written: it does
matter, effectively.
Kind regards,
Nicolas
Attachment:
signature.asc
Description: PGP signature
