Please find comments inline. Regards Varun > -----Original Message----- > From: Pankaj Gupta <pankaj.gupta@xxxxxxx> > Sent: Friday, August 25, 2023 12:56 PM > To: Varun Sethi <V.Sethi@xxxxxxx> > Subject: FW: [EXT] Re: [PATCH v5 01/11] dt-bindings: arm: fsl: add imx-se-fw > binding doc > > > > -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: Friday, August 25, 2023 12:16 AM > To: Rob Herring <robh@xxxxxxxxxx>; Pankaj Gupta <pankaj.gupta@xxxxxxx> > Cc: shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; > kernel@xxxxxxxxxxxxxx; clin@xxxxxxxx; conor+dt@xxxxxxxxxx; > pierre.gondois@xxxxxxx; Jacky Bai <ping.bai@xxxxxxx>; Clark Wang > <xiaoning.wang@xxxxxxx>; Wei Fang <wei.fang@xxxxxxx>; Peng Fan > <peng.fan@xxxxxxx>; Bough Chen <haibo.chen@xxxxxxx>; > festevam@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; > davem@xxxxxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; Gaurav Jain <gaurav.jain@xxxxxxx>; > alexander.stein@xxxxxxxxxxxxxxx; Sahil Malhotra > <sahil.malhotra@xxxxxxx>; Aisheng Dong <aisheng.dong@xxxxxxx>; Varun > Sethi <V.Sethi@xxxxxxx>; Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> > Subject: [EXT] Re: [PATCH v5 01/11] dt-bindings: arm: fsl: add imx-se-fw > binding doc > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On 23/08/2023 14:43, Rob Herring wrote: > >> + | > >> + +------------------------------------------------------ | > >> + | | | | > >> + userspace /dev/ele_muXch0 | | | > >> + /dev/ele_muXch1 | | > >> + /dev/ele_muXchY | > >> + | > >> + > >> + When a user sends a command to the firmware, it registers its > >> + device_ctx as waiter of a response from firmware. > >> + > >> + A user can be registered as receiver of command from the ELE. > >> + Create char devices in /dev as channels of the form > >> + /dev/ele_muXchY with X the id of the driver and Y for each users. > >> + It allows to send and receive messages to the NXP EdgeLock Enclave > >> + IP firmware on NXP SoC, where current possible value, i.e., supported > SoC(s) are imx8ulp, imx93. > > > > Looks like a bunch of Linux details which don't belong in the binding. > > > > Why do you need your own custom interface to userspace? No one else > > has a similar feature in their platforms? Something like virtio or > > rpmsg doesn't work? > > +Cc Greg, > > I doubt they care. This is some stub-driver to pass messages from user-space > to the firmware. The interface is undocumented, without examples and no > user-space user. > > Best regards, > Krzysztof [Varun] The goal of the driver is to pass messages between firmware and user space/kernel consumers. At the same time driver also enables firmware to use the storage via Linux user space. We do have middleware applications that utilize the driver. These applications leverage cryptographic operations and trust provisioning capabilities offered by the firmware. We can provide references to the middleware applications in the next version of the patch. We do plan to enable the kernel crypto API interface to leverage operations provided by the firmware. The operations that are exposed by the firmware are performance-sensitive and session-based (thus serialized). So, the Virtio/rpmsg model is not suited for our implementation. Also, the secure enclave IP, with which the driver facilitates the communication is an opaque block that doesn't fit the rpmsg model.
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
