On Thu, 18 Dec 2014, Hans de Goede wrote: > Hi, > > On 18-12-14 09:41, Lee Jones wrote: > >On Wed, 17 Dec 2014, Hans de Goede wrote: > > > >>Add support for the ir-clk which is part of the sun6i SoC prcm module. > >> > >>Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > >>--- > >> drivers/mfd/sun6i-prcm.c | 14 ++++++++++++++ > >> 1 file changed, 14 insertions(+) > > > >Pretty standard stuff ( > > > >>diff --git a/drivers/mfd/sun6i-prcm.c b/drivers/mfd/sun6i-prcm.c > >>index 2f2e9f0..1911731 100644 > >>--- a/drivers/mfd/sun6i-prcm.c > >>+++ b/drivers/mfd/sun6i-prcm.c > >>@@ -41,6 +41,14 @@ static const struct resource sun6i_a31_apb0_gates_clk_res[] = { > >> }, > >> }; > >> > >>+static const struct resource sun6i_a31_ir_clk_res[] = { > >>+ { > >>+ .start = 0x54, > >>+ .end = 0x57, > >>+ .flags = IORESOURCE_MEM, > >>+ }, > >>+}; > > > >I'm still unkeen on this registers not being defined -- but whateveer! > > > >> static const struct resource sun6i_a31_apb0_rstc_res[] = { > >> { > >> .start = 0xb0, > >>@@ -69,6 +77,12 @@ static const struct mfd_cell sun6i_a31_prcm_subdevs[] = { > >> .resources = sun6i_a31_apb0_gates_clk_res, > >> }, > >> { > >>+ .name = "sun6i-a31-ir-clk", > >>+ .of_compatible = "allwinner,sun4i-a10-mod0-clk", > >>+ .num_resources = ARRAY_SIZE(sun6i_a31_ir_clk_res), > >>+ .resources = sun6i_a31_ir_clk_res, > >>+ }, > >>+ { > >> .name = "sun6i-a31-apb0-clock-reset", > >> .of_compatible = "allwinner,sun6i-a31-clock-reset", > >> .num_resources = ARRAY_SIZE(sun6i_a31_apb0_rstc_res), > > > >This is all pretty standard stuff: > > > >For my own reference: > > > >Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> > > > >Do you do you expect this patch to be handled? > > I've no preference for how this goes upstream. There are no compile time deps > and runtime the ir will not work (but not explode) until all the bits are > in place. Great, this is my kind of patch. Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html