> -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: Wednesday, August 23, 2023 1:59 PM > To: Pankaj Gupta <pankaj.gupta@xxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Bough Chen > <haibo.chen@xxxxxxx>; festevam@xxxxxxxxx; Peng Fan > <peng.fan@xxxxxxx>; conor+dt@xxxxxxxxxx; Varun Sethi > <V.Sethi@xxxxxxx>; Sahil Malhotra <sahil.malhotra@xxxxxxx>; > shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; clin@xxxxxxxx; Gaurav Jain > <gaurav.jain@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; > robh+dt@xxxxxxxxxx; Jacky Bai <ping.bai@xxxxxxx>; > krzysztof.kozlowski+dt@xxxxxxxxxx; Aisheng Dong <aisheng.dong@xxxxxxx>; > Clark Wang <xiaoning.wang@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx; > davem@xxxxxxxxxxxxx; Wei Fang <wei.fang@xxxxxxx>; > alexander.stein@xxxxxxxxxxxxxxx; pierre.gondois@xxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx > Subject: [EXT] Re: [PATCH v5 01/11] dt-bindings: arm: fsl: add imx-se-fw > binding doc > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On Wed, 23 Aug 2023 13:03:20 +0530, Pankaj Gupta wrote: > > The NXP's i.MX EdgeLock Enclave, a HW IP creating an embedded secure > > enclave within the SoC boundary to enable features like > > - HSM > > - SHE > > - V2X > > > > Communicates via message unit with linux kernel. This driver is > > enables communication ensuring well defined message sequence protocol > > between Application Core and enclave's firmware. > > > > Driver configures multiple misc-device on the MU, for multiple > > user-space applications can communicate on single MU. > > > > It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc. > > > > Signed-off-by: Pankaj Gupta <pankaj.gupta@xxxxxxx> > > --- > > .../bindings/firmware/fsl,imx-se-fw.yaml | 121 ++++++++++++++++++ > > 1 file changed, 121 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/firmware/fsl,imx-se-fw.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m > dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review- > ci/linux/Documentation/devicetree/bindings/firmware/fsl,imx-se- > fw.example.dtb: se-fw: 'mu-id' is a required property > from schema $id: > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetr > ee.org%2Fschemas%2Ffirmware%2Ffsl%2Cimx-se- > fw.yaml%23&data=05%7C01%7Cpankaj.gupta%40nxp.com%7C7e28c89d24c6 > 4b9c000108dba3b2f2d0%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7 > C0%7C638283761210875688%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4 > wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C > %7C%7C&sdata=SFldwBvByjOkEf%2FlzBmMJ3oZI9cBdWJe1ZmSh2AsflA%3D&r > eserved=0 > /builds/robherring/dt-review- > ci/linux/Documentation/devicetree/bindings/firmware/fsl,imx-se- > fw.example.dtb: se-fw: 'fsl,mu-id' does not match any of the regexes: 'pinctrl- > [0-9]+' > from schema $id: > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetr > ee.org%2Fschemas%2Ffirmware%2Ffsl%2Cimx-se- > fw.yaml%23&data=05%7C01%7Cpankaj.gupta%40nxp.com%7C7e28c89d24c6 > 4b9c000108dba3b2f2d0%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7 > C0%7C638283761210875688%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4 > wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C > %7C%7C&sdata=SFldwBvByjOkEf%2FlzBmMJ3oZI9cBdWJe1ZmSh2AsflA%3D&r > eserved=0 > > doc reference errors (make refcheckdocs): > > See > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchw > ork.ozlabs.org%2Fproject%2Fdevicetree- > bindings%2Fpatch%2F20230823073330.1712721-2- > pankaj.gupta%40nxp.com&data=05%7C01%7Cpankaj.gupta%40nxp.com%7C7 > e28c89d24c64b9c000108dba3b2f2d0%7C686ea1d3bc2b4c6fa92cd99c5c30 > 1635%7C0%7C0%7C638283761210875688%7CUnknown%7CTWFpbGZsb3d8 > eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D > %7C3000%7C%7C%7C&sdata=afDClssaony%2B7aLwRX8VWJ1QyPrfZJJnEOcyU > LYxR4g%3D&reserved=0 > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above error(s), > then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. Accepted. Re-submitting the patch V6 by end of this, after fixing it.