On 22/08/2023 22:43, Raphael Gallais-Pou wrote:
> Convert the st,stih407-usb2-phy binding to DT schema format.
>
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@xxxxxxxxx>
> ---
Thank you for your patch. There is something to discuss/improve. Minor
change needed at the end. While at it, few more nits (which I would skip
if not that change).
> Changes in v2:
> * Removed quotes surrounding $ref
> * Removed quotes surrounding const properties
> * Changed 'st,syscfg' $ref value to phandle-array
> * Changed authorship to my oss email addressThank you for your patch. There is something to discuss/improve.
Nit: Drop "driver" and any other driver references. Instead, focus on
device.
> + (when controlling usb2/1.1 devices) available on STiH407 SoC family from
> + STMicroelectronics.
> +
> +properties:
> + compatible:
> + const: st,stih407-usb2-phy
> +
> + st,syscfg:
> + description: Phandle to the syscfg bank
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + - items:
> + - description: phandle to syscfg
> + - description: phyparam register offset
> + - description: phyctrl register offset
> +
> + resets:
> + items:
> + - description: Phandle and reset specifier pair for the whole phy.
> + - description: Phandle and reset specifier pair for the port.
> +
> + reset-names:
> + description: List of reset signal names.
Nit: drop description, it is obvious.
> + items:
> + - const: global
> + - const: port
> +
> + "#phy-cells":
> + const: 0
> +
> +required:
> + - compatible
> + - st,syscfg
> + - resets
> + - reset-names
> + - "#phy-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/reset/stih407-resets.h>
> + usb2_picophy0: usbpicophy {
Drop unused label, and make node name as: usb-phy or phy
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
