On Mon, Aug 21, 2023 at 07:14:04PM +0100, Russell King (Oracle) wrote: > On Thu, Aug 17, 2023 at 06:06:38PM +0300, Vladimir Oltean wrote: > > As opposed to PHY_MODE_ETHERNET which takes a phy_interface_t as is > > expected to be used by an Ethernet MAC driver, PHY_MODE_ETHERNET takes > > an enum ethtool_link_mode_bit_indices and expects to be used by an > > Ethernet PHY driver. > > This doesn't seem to be correct. I think one of your PHY_MODE_ETHERNET > above should be PHY_MODE_ETHERNET_PHY - but maybe instead it should > be PHY_MODE_ETHTOOL so that it's clearly different and doesn't get > confused with PHY_MODE_ETHERNET ? > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! Correct, sorry for the incorrect commit description. PHY_MODE_ETHTOOL would also work perfectly fine to me, and is more explicit.
