On Mon, Aug 21, 2023 at 8:05 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Rob, > > Thanks for your patch! > > > On Fri, Aug 18, 2023 at 10:41 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > The changeset code checks for a property in the deadprops list when > > adding/updating a property, but of_add_property() and > > of_update_property() do not. As the users of these functions are pretty > > simple, they have not hit this scenario or else the property lists > > would get corrupted. > > > > With this there are 3 cases of removing a property from either deadprops > > or properties lists, so add a helper to find and remove a matching > > property. > > > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Thanks! > > Perhaps this needs a Fixes tag? I didn't simply because in the decades that these functions existed, no one cared. It would require a specific sequence of calls which we could pretty much determine doesn't happen just looking at the callers in the kernel. Rob
