On Sat, Aug 19, 2023 at 10:26 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 16/08/2023 13:13, Keguang Zhang wrote: > > Add devicetree binding document for Loongson-1 DWMAC glue layer. > > > > Signed-off-by: Keguang Zhang <keguang.zhang@xxxxxxxxx> > > --- > > V1 -> V2: Fix "clock-names" and "interrupt-names" property > > Rename the syscon property to "loongson,dwmac-syscon" > > Drop "phy-handle" and "phy-mode" requirement > > Revert adding loongson,ls1b-dwmac/loongson,ls1c-dwmac > > to snps,dwmac.yaml > > > > .../bindings/net/loongson,ls1x-dwmac.yaml | 98 +++++++++++++++++++ > > 1 file changed, 98 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/loongson,ls1x-dwmac.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/loongson,ls1x-dwmac.yaml b/Documentation/devicetree/bindings/net/loongson,ls1x-dwmac.yaml > > new file mode 100644 > > index 000000000000..cf5477450e29 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/loongson,ls1x-dwmac.yaml > > @@ -0,0 +1,98 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/loongson,ls1x-dwmac.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Loongson-1 DWMAC glue layer > > Please implement Serge's comments about title and description. Rest > looks good: > Will do. > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > As suggested by Serge, this file will be split into loongson,ls1b-gmac.yaml and loongson,ls1c-mac.yaml. Due to this significant change, I'm not sure whether I should keep your Reviewed-by tag or not. Thanks! > Best regards, > Krzysztof > -- Best regards, Keguang Zhang
