On 21/08/2023 02:25, Dmitry Baryshkov wrote: > Migrate legacy bindings (described in qcom,msm8996-qmp-usb3-phy.yaml) > to qcom,sc8280xp-qmp-usb3-uni-phy.yaml. This removes a need to declare > the child PHY node or split resource regions. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml > index f99fbbcd68fb..60cbcf3c19b3 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml > @@ -16,20 +16,33 @@ description: > properties: > compatible: > enum: > + - qcom,ipq6018-qmp-usb3-phy > + - qcom,ipq8074-qmp-usb3-phy > - qcom,ipq9574-qmp-usb3-phy > + - qcom,msm8996-qmp-usb3-phy > + - qcom,msm8998-qmp-usb3-phy > - qcom,qcm2290-qmp-usb3-phy > - qcom,sa8775p-qmp-usb3-uni-phy > - qcom,sc8280xp-qmp-usb3-uni-phy > + - qcom,sdm845-qmp-usb3-uni-phy > + - qcom,sdx55-qmp-usb3-uni-phy > + - qcom,sdx65-qmp-usb3-uni-phy > - qcom,sm6115-qmp-usb3-phy > + - qcom,sm8150-qmp-usb3-uni-phy > + - qcom,sm8250-qmp-usb3-uni-phy > + - qcom,sm8350-qmp-usb3-uni-phy > + > Just one blank line > reg: > maxItems: 1 > > clocks: > - maxItems: 4 > + minItems: 4 > + maxItems: 5 The clocks become now variable, so you need to constrain the number in allOf:if:then per each variant. At least one if: cases lack such constrains (qcom,ipq9574-qmp-usb3-phy, if I am looking at correct revision) Best regards, Krzysztof