On 31/07/2023 12:57, Dmitry Baryshkov wrote: > Migrate legacy bindings (described in qcom,ipq8074-qmp-pcie-phy.yaml) > to qcom,sc8280xp-qmp-pcie-phy.yaml. This removes a need to declare > the child PHY node or split resource regions. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > --- > .../phy/qcom,ipq8074-qmp-pcie-phy.yaml | 278 +++--------------- > .../phy/qcom,msm8998-qmp-pcie-phy.yaml | 97 ++++++ > .../phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 34 ++- > 3 files changed, 163 insertions(+), 246 deletions(-) > create mode 100644 Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-pcie-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.yaml > index 3d42ee3901a1..5073007267ad 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.yaml > @@ -13,287 +13,79 @@ description: > QMP PHY controller supports physical layer functionality for a number of > controllers on Qualcomm chipsets, such as, PCIe, UFS, and USB. > > - Note that these bindings are for SoCs up to SC8180X. For newer SoCs, see > - qcom,sc8280xp-qmp-pcie-phy.yaml. > - > properties: > compatible: > enum: > - qcom,ipq6018-qmp-pcie-phy > - qcom,ipq8074-qmp-gen3-pcie-phy > - qcom,ipq8074-qmp-pcie-phy > - - qcom,msm8998-qmp-pcie-phy > - - qcom,sc8180x-qmp-pcie-phy > - - qcom,sdm845-qhp-pcie-phy > - - qcom,sdm845-qmp-pcie-phy > - - qcom,sdx55-qmp-pcie-phy > - - qcom,sm8250-qmp-gen3x1-pcie-phy > - - qcom,sm8250-qmp-gen3x2-pcie-phy > - - qcom,sm8250-qmp-modem-pcie-phy > - - qcom,sm8450-qmp-gen3x1-pcie-phy > - - qcom,sm8450-qmp-gen4x2-pcie-phy ... > + #phy-cells = <0>; > + > + resets = <&gcc GCC_PCIE_0_PHY_BCR>, <&gcc GCC_PCIE_PHY_BCR>; > + reset-names = "phy", "common"; > + > + vdda-phy-supply = <&vreg_l1a_0p875>; > + vdda-pll-supply = <&vreg_l2a_1p2>; > + }; > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > index ca55ed9d74ac..a2c894a33c1c 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > @@ -18,11 +18,21 @@ properties: > enum: > - qcom,sa8775p-qmp-gen4x2-pcie-phy > - qcom,sa8775p-qmp-gen4x4-pcie-phy > + - qcom,sc8180x-qmp-pcie-phy > - qcom,sc8280xp-qmp-gen3x1-pcie-phy > - qcom,sc8280xp-qmp-gen3x2-pcie-phy > - qcom,sc8280xp-qmp-gen3x4-pcie-phy > + - qcom,sdm845-qhp-pcie-phy > + - qcom,sdm845-qmp-pcie-phy > + - qcom,sdx55-qmp-pcie-phy > - qcom,sdx65-qmp-gen4x2-pcie-phy > + - qcom,sm8150-qmp-gen3x1-pcie-phy This was not present before. If you add new compatible, split it to new patch. > + - qcom,sm8250-qmp-gen3x1-pcie-phy > + - qcom,sm8250-qmp-gen3x2-pcie-phy > + - qcom,sm8250-qmp-modem-pcie-phy > - qcom,sm8350-qmp-gen3x1-pcie-phy > + - qcom,sm8450-qmp-gen3x1-pcie-phy > + - qcom,sm8450-qmp-gen4x2-pcie-phy > - qcom,sm8550-qmp-gen3x2-pcie-phy > - qcom,sm8550-qmp-gen4x2-pcie-phy The rest looks good to me. Best regards, Krzysztof
