On 19/08/2023 03:09, Rob Herring wrote: > The Aspeed pinctrl bindings are missing an additionalProperties/ > unevaluatedProperties schemas on the child pin mux nodes which means any > undefined properties are allowed. In addition, using > 'additionalProperties' for child nodes with any name works better than a > pattern matching everything with an if/then schema to select nodes only. > > With 'additionalProperties' added, 'pins' and 'bias-disable' > properties need to be added as they were not defined. A $ref to > pinmux-node.yaml which defines the common property types was also > missing. > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > --- > Really 'pins' should have some constraints, but I don't know what the > possible values are. Happy to add if someone can tell me what. > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
