On 18/08/2023 23:06, Shenwei Wang wrote: > > >> -----Original Message----- >> From: Rob Herring <robh+dt@xxxxxxxxxx> >> Sent: Friday, August 18, 2023 3:52 PM >> To: Shenwei Wang <shenwei.wang@xxxxxxx> >> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley >> <conor+dt@xxxxxxxxxx>; Ulf Hansson <ulf.hansson@xxxxxxxxxx>; Liam Girdwood >> <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; >> imx@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >> dl-linux-imx <linux-imx@xxxxxxx> >> Subject: [EXT] Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml file >>> >>> Documenting the regulator power domain properties and usage examples. >> >> This needs to answer why we need this. >> >> It looks like just an abstraction layer to make regulators look like a power >> domain. >> > > Yes, it is a wrapper that allows using regulators as a power domain. This removes > the need to add regulator operating code in each consumer device driver. As a power > domain, the regulator will be managed automatically by the device driver framework > and PM subsystem. > > This is very useful when a device's power is controlled by a GPIO pin, which currently > requires using the fixed-regulator to achieve the same purpose. However, the > fixed-regulator approach may have to add code in the driver in order to use it. Why do you start discussion from zero ignoring all previous history of this patchset? https://lore.kernel.org/all/20220609150851.23084-1-max.oss.09@xxxxxxxxx/ Best regards, Krzysztof
