On Aug 10 2023 11:49, Guru Das Srinagesh wrote: > On Aug 03 2023 11:16, Neil Armstrong wrote: > > Hi, > > > > On 03/08/2023 10:23, Guru Das Srinagesh wrote: > > >When pushing patches to upstream, the `get_maintainer.pl` script is used to > > >determine whom to send the patches to. Instead of having to manually process > > >the output of the script, add a wrapper script to do that for you. > > > > > >The add-maintainer.py script adds maintainers (and mailing lists) to a patch, > > >editing it in-place. > > > > FYI the b4 prep command does this: > > https://github.com/mricon/b4/blob/e8045d1353165cc065b2f1b180bf1b0846af510e/b4/ez.py#L2055 > > > > Perhaps it could be useful to make sure the output is similar ? > > > > So far I've been very satisfied by the output of b4 auto_to_cc. > > Thank you - let me check this tool out. I gave `b4` a spin and specifically compared the results of `b4 prep --auto-to-cc` vs this script. I notice from the code that b4 calls `get_maintainer.pl` with the following flags: --nogit --nogit-fallback --nogit-chief-penguins I can add these to this script too. And it collects maintainers and lists by passing, respectively, `--nol` and `--nom` in two separate calls whereas this script parses the actual roles by making only one call. b4's approach seems cleaner. The perl script also can provide just the reviewers by passing `--nol --nom`. b4 and this script both do: - Create set-union of all maintainers and all lists from all patches in a series. - Apply the same addresses to all patches in a series. The main thing b4 doesn't do (which this script does) is: - add only that specific patch's maintainers as "To: ", and - the other maintainers from the other patches as "Cc: " Overall, b4 seems like a fantastic feature-rich tool for managing and sending patches. Thank you for sharing the link to the actual code - it was very instructive. Guru Das.
