On Fri, Aug 18, 2023 at 09:53:50PM +0800, Rohan G Thomas wrote:
>> + u32 flags;
>
>This looks redundant. See my last comment.
>
>> +
>
>> + u32 tx_q_with_coe;
>
>This one too. Can't you just use the
>plat_stmmacenet_data.tx_queues_with_coe field?
>
>> + if (priv->plat->tx_coe &&
>> + priv->plat->tx_queues_with_coe < priv->plat->tx_queues_to_use) {
>> + priv->flags |= STMMAC_PRIV_FLG_TXQ_COE_LIMIT;
>> + priv->tx_q_with_coe = priv->plat->tx_queues_with_coe;
>> + dev_info(priv->device, "TX COE limited to %u tx queues\n",
>> + priv->tx_q_with_coe);
>> + }
>
>What about:
>+ if (priv->plat->tx_coe && !priv->plat->tx_queues_with_coe)
>+ priv->plat->tx_queues_with_coe = priv->plat->tx_queues_to_use;
>+ else if (!priv->plat->tx_coe)
>+ priv->plat->tx_queues_with_coe = 0;
>+ else if (priv->plat->tx_queues_with_coe < priv->plat->tx_queues_to_use)
>+ dev_info(priv->device, "TX COE is available for %u queues\n", priv->plat->tx_queues_with_coe);
>
>?
>
>-Serge(y)
Hi Serge,
Agreed.
Thanks for the suggestion. Will rework in next version.
BR,
Rohan
>>
>>
