Hi Sarah, thanks for your patch! Patches adding device tree bindings need to be CC:ed to devicetree@xxxxxxxxxxxxxxx and the DT binding maintainers, I have added it for now. On Wed, Aug 16, 2023 at 10:26 AM Sarah Walker <sarah.walker@xxxxxxxxxx> wrote: > Add the device tree binding documentation for the Series AXE GPU used in > TI AM62 SoCs. > > Co-developed-by: Frank Binns <frank.binns@xxxxxxxxxx> > Signed-off-by: Frank Binns <frank.binns@xxxxxxxxxx> > Signed-off-by: Sarah Walker <sarah.walker@xxxxxxxxxx> (...) > +properties: > + compatible: > + items: > + - enum: > + - ti,am62-gpu > + - const: img,powervr-seriesaxe Should there not at least be a dash there? img,powervr-series-axe? It is spelled in two words in the commit message, Series AXE not SeriesAXE? Moreover, if this pertains to the AXE-1-16 and AXE-2-16 it is kind of a wildcard and we usually don't do that, I would use the exact version instead, such as: const: img,powervr-axe-1-16 any reason not to do this? I asked about the relationship between these strings and the product designations earlier I think :/ Yours, Linus Walleij
