On 17/08/2023 18:26, Rob Herring wrote: > On Tue, Aug 15, 2023 at 10:36:39PM +0200, Krzysztof Kozlowski wrote: >> On 15/08/2023 01:59, Anjelique Melendez wrote: >>> Add binding for the Qualcomm Programmable Boot Sequencer device. >>> >>> Signed-off-by: Anjelique Melendez <quic_amelende@xxxxxxxxxxx> >>> --- >>> .../bindings/soc/qcom/qcom,pbs.yaml | 46 +++++++++++++++++++ >>> 1 file changed, 46 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml >>> new file mode 100644 >>> index 000000000000..b502ca72266a >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml >>> @@ -0,0 +1,46 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/soc/qcom/qcom,pbs.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm Technologies, Inc. Programmable Boot Sequencer >>> + >>> +maintainers: >>> + - Anjelique Melendez <quic_amelende@xxxxxxxxxxx> >>> + >>> +description: | >>> + The Qualcomm Technologies, Inc. Programmable Boot Sequencer (PBS) >>> + supports triggering power up and power down sequences for clients >>> + upon request. >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - qcom,pmi632-pbs >>> + - const: qcom,pbs >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> +required: >>> + - compatible >>> + - reg >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + #include <dt-bindings/spmi/spmi.h> >>> + >>> + pmic@0 { >> >> This should be rather just "pmic", because the examples have >> address-cells=1 and size-cells=1, which is not correct in this context. > > But there's a 'reg' property so you can't drop the unit-address. The bus > node (spmi) needs to be added. reg also can be dropped. I am not sure whether parent PMIC bus is important here. Best regards, Krzysztof
