On Thu, Aug 17, 2023 at 01:57:39PM +0300, Andy Shevchenko wrote: > On Sat, Aug 12, 2023 at 08:24:11PM +0800, Peng Fan (OSS) wrote: ... > > - device_set_node(&dev->dev, of_fwnode_handle(node)); > > + device_set_node(&dev->dev, fwnode_handle_get(fwnode)); > > Ditto. Actually no, amba_device_alloc() does not use platform_device_alloc() and defines it's own .release method. There is no reference count drop there AFAICS. -- With Best Regards, Andy Shevchenko