Hi Krzysztof: Thanks for your reply. On Tue, Aug 15, 2023 at 10:49 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 15/08/2023 10:50, Binbin Zhou wrote: > > Add Loongson SoC boards binding with DT schema format using json-schema. > > > > Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx> > > --- > > .../devicetree/bindings/loongarch/boards.yaml | 34 +++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/loongarch/boards.yaml > > > > diff --git a/Documentation/devicetree/bindings/loongarch/boards.yaml b/Documentation/devicetree/bindings/loongarch/boards.yaml > > new file mode 100644 > > index 000000000000..5092314b7a52 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/loongarch/boards.yaml > > @@ -0,0 +1,34 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/loongarch/boards.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Loongson SoC-based boards > > + > > +maintainers: > > + - Binbin Zhou <zhoubinbin@xxxxxxxxxxx> > > + > > +properties: > > + $nodename: > > + const: '/' > > + compatible: > > + oneOf: > > + - description: Loongson-2K0500 processor based boards > > + items: > > + - const: loongson,ls2k0500-ref > > + - const: loongson,ls2k0500 > > + > > + - description: Loongson-2K1000 processor based boards > > + items: > > + - const: loongson,ls2k1000-ref > > + - const: loongson,ls2k1000 > > + > > + - description: Loongson-2K2000 processor based boards > > + items: > > + - const: loongson,ls2k2000-ref > > + - const: loongson,ls2k2000 > > This probably is a sign all your bindings are using a bogus compatible. > You were using compatibles like loongson,ls2k-clk so your SoC cannot be > ls2k2000... or your compatible is bogus. The same for: > loongson,ls2k-pm, loongson,ls2k-dwmac, loongson,ls2k-i2c, > loongson,ls2k-chipid, loongson,ls2k-gpio > I'm not sure I understand correctly, are you saying I should rename all these ls2k-xx compatibles to Soc-based compatible? For example, loongson,ls2k-i2c should be renamed to something like this: loongson,ls2k0500-i2c, loongson,ls2k-i2c loongson,ls2k1000-i2c, loongson,ls2k-i2c loongson,ls2k2000-i2c, loongson,ls2k-i2c Even if their driver code is no different. Thanks. Binbin > Best regards, > Krzysztof >
