On Wed, Aug 16, 2023 at 09:27:25AM +0100, Sarah Walker wrote: > Add the device tree binding documentation for the Series AXE GPU used in > TI AM62 SoCs. > > Co-developed-by: Frank Binns <frank.binns@xxxxxxxxxx> > Signed-off-by: Frank Binns <frank.binns@xxxxxxxxxx> > Signed-off-by: Sarah Walker <sarah.walker@xxxxxxxxxx> This seems okay to me, Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Thanks, Conor. > --- > Changes since v4: > - Add clocks constraint for ti,am62-gpu > - Remove excess address and size cells in example > - Remove interrupt name and add maxItems > - Make property order consistent between dts and bindings doc > - Update example to match dts > > Changes since v3: > - Remove oneOf in compatible property > - Remove power-supply (not used on AM62) > > Changes since v2: > - Add commit message description > - Remove mt8173-gpu support (not currently supported) > - Drop quotes from $id and $schema > - Remove reg: minItems > - Drop _clk suffixes from clock-names > - Remove operating-points-v2 property and cooling-cells (not currently > used) > - Add additionalProperties: false > - Remove stray blank line at the end of file > > .../devicetree/bindings/gpu/img,powervr.yaml | 75 +++++++++++++++++++ > MAINTAINERS | 7 ++ > 2 files changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpu/img,powervr.yaml > > diff --git a/Documentation/devicetree/bindings/gpu/img,powervr.yaml b/Documentation/devicetree/bindings/gpu/img,powervr.yaml > new file mode 100644 > index 000000000000..40ade5ceef6e > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpu/img,powervr.yaml > @@ -0,0 +1,75 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2023 Imagination Technologies Ltd. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpu/img,powervr.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Imagination Technologies PowerVR GPU > + > +maintainers: > + - Sarah Walker <sarah.walker@xxxxxxxxxx> > + > +properties: > + compatible: > + items: > + - enum: > + - ti,am62-gpu > + - const: img,powervr-seriesaxe > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 1 > + maxItems: 3 > + > + clock-names: > + items: > + - const: core > + - const: mem > + - const: sys > + minItems: 1 > + > + interrupts: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + > +additionalProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: ti,am62-gpu > + then: > + properties: > + clocks: > + maxItems: 1 > + clock-names: > + const: core > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/soc/ti,sci_pm_domain.h> > + > + gpu: gpu@fd00000 { > + compatible = "ti,am62-gpu", "img,powervr-seriesaxe"; > + reg = <0x0fd00000 0x20000>; > + clocks = <&k3_clks 187 0>; > + clock-names = "core"; > + interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>; > + power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index cd882b87a3c6..f84390bb6cfe 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10138,6 +10138,13 @@ IMGTEC IR DECODER DRIVER > S: Orphan > F: drivers/media/rc/img-ir/ > > +IMGTEC POWERVR DRM DRIVER > +M: Frank Binns <frank.binns@xxxxxxxxxx> > +M: Sarah Walker <sarah.walker@xxxxxxxxxx> > +M: Donald Robson <donald.robson@xxxxxxxxxx> > +S: Supported > +F: Documentation/devicetree/bindings/gpu/img,powervr.yaml > + > IMON SOUNDGRAPH USB IR RECEIVER > M: Sean Young <sean@xxxxxxxx> > L: linux-media@xxxxxxxxxxxxxxx > -- > 2.41.0 >
Attachment:
signature.asc
Description: PGP signature
