> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx] > Sent: 15 August 2023 01:12 > To: Sriranjani P <sriranjani.p@xxxxxxxxxxx>; davem@xxxxxxxxxxxxx; > edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; > robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > conor+dt@xxxxxxxxxx; richardcochran@xxxxxxxxx; > alexandre.torgue@xxxxxxxxxxx; joabreu@xxxxxxxxxxxx; > mcoquelin.stm32@xxxxxxxxx; alim.akhtar@xxxxxxxxxxx; linux- > fsd@xxxxxxxxx; pankaj.dubey@xxxxxxxxxxx; swathi.ks@xxxxxxxxxxx; > ravi.patel@xxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; Jayati Sahu <jayati.sahu@xxxxxxxxxxx> > Subject: Re: [PATCH v3 4/4] arm64: dts: fsd: Add Ethernet support for PERIC > Block of FSD SoC > > On 14/08/2023 21:41, Krzysztof Kozlowski wrote: > > On 14/08/2023 13:25, Sriranjani P wrote: > >> The FSD SoC contains two instances of Synopsys DWC QoS Ethernet IP, > >> one in > >> FSYS0 block and other in PERIC block. > >> > >> Adds device tree node for Ethernet in PERIC Block and enables the > >> same for FSD platform. > >> > >> Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> > >> Signed-off-by: Jayati Sahu <jayati.sahu@xxxxxxxxxxx> > >> Signed-off-by: Swathi K S <swathi.ks@xxxxxxxxxxx> > >> Signed-off-by: Sriranjani P <sriranjani.p@xxxxxxxxxxx> > >> --- > >> arch/arm64/boot/dts/tesla/fsd-evb.dts | 9 ++++ > >> arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 56 > ++++++++++++++++++++++ > >> arch/arm64/boot/dts/tesla/fsd.dtsi | 29 +++++++++++ > >> 3 files changed, 94 insertions(+) > > > > Looks duplicated. > > Ah, not, it's another block. > > My question whether this was tested remains... I understand your concern. It was tested but just before posting I addressed one of earlier review comment of compatible and I missed to reflect it in all the patches. I will take care. > > Best regards, > Krzysztof