On 14/08/2023 10:53, Eugen Hristev wrote: > Convert the mediatek,audsys binding to YAML. > > Signed-off-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx> > --- > Changes in v2: > - remove comment reference to inexistent binding This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. ... > + > + audio-controller: > + type: object > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + audsys: clock-controller@11220000 { > + compatible = "mediatek,mt7622-audsys", "syscon"; > + reg = <0 0x11220000 0 0x2000>; > + #clock-cells = <1>; > + > + audio-controller { The binding and example are incomplete. This should be sent together with the afe conversion. Best regards, Krzysztof