Dear Paul, Thank you for your comments. I originally wanted to judge whether to match chip data by DT compatible, but it does not make sense. Therefore, I will remove it in the v4 version. Thanks. Best regard, Mia > On Aug 10, 2023, at 3:55 PM, Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote: > > Dear Mia, > > > Thank you for your patch. It’d be great if you mentioned nct3015y in the commit message summary/title. Maybe: > > dt-bindings: rtc: Add compatible nct3015y to nuvoton,nct3018y > >> Am 09.08.23 um 11:51 schrieb Mia Lin: >> Add DT compatible "nuvoton,nct3015y" to select > > What do you mean by “to select”? > > Also, maybe add how you tested this. > >> Signed-off-by: Mia Lin <mimi05633@xxxxxxxxx> >> --- >> Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> diff --git a/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml b/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml >> index 4f9b5604acd9..67fc60fd395c 100644 >> --- a/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml >> +++ b/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml >> @@ -15,7 +15,9 @@ maintainers: >> properties: >> compatible: >> - const: nuvoton,nct3018y >> + enum: >> + - nuvoton,nct3018y >> + - nuvoton,nct3015y > > Would sorting the list be useful? > >> reg: >> maxItems: 1 > > > Kind regards, > > Paul
