On 21:26-20230814, Krzysztof Kozlowski wrote: > On 12/08/2023 00:49, Nishanth Menon wrote: Looping in Vinod [...] > > A bit too fast. simple-mfd *is not allowed* on its own. > Actually dtbs_check comes up clean, but more I dug at it, looks like we should probably cleanup. (everything): https://gist.github.com/nmenon/5f5f689333c66697969f5d80ad94cfca (am62p alone): https://gist.github.com/nmenon/9aaa2067a619b12af338647d19b4cf9b $ git grep 'compatible = "simple-mfd";' arch/arm64/boot/dts/ti/ arch/arm64/boot/dts/ti/k3-am62-main.dtsi: compatible = "simple-mfd"; arch/arm64/boot/dts/ti/k3-am62p-main.dtsi: compatible = "simple-mfd"; arch/arm64/boot/dts/ti/k3-am64-main.dtsi: compatible = "simple-mfd"; arch/arm64/boot/dts/ti/k3-am65-main.dtsi: compatible = "simple-mfd"; arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi: compatible = "simple-mfd"; arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: compatible = "simple-mfd"; arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi: compatible = "simple-mfd"; arch/arm64/boot/dts/ti/k3-j721e-main.dtsi: compatible = "simple-mfd"; arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi: compatible = "simple-mfd"; arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi: compatible = "simple-mfd"; arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi: compatible = "simple-mfd"; It is all over our k3 dts folder for dma. Digging further, it looks to have been explicitly permitted by the bindings: $ git grep 'compatible = "simple-mfd";' Documentation/devicetree/bindings/ Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml: compatible = "simple-mfd"; Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml: compatible = "simple-mfd"; Documentation/devicetree/bindings/dma/ti/k3-udma.yaml: compatible = "simple-mfd"; Looks like we will have to cleanup the yaml bindings and the dts nodes in a manner that doesn't break the platforms. I am not saying that simple-mfd usage is correct, but it was explicitly permitted by schema in these instances, are you OK that we clean that in the upcoming merge window as the very first thing we do and let this series through? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
