On 14/08/2023 13:25, Sriranjani P wrote: > Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD > Ethernet YAML schema to enable the DT validation. > > Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> > Signed-off-by: Ravi Patel <ravi.patel@xxxxxxxxxxx> > Signed-off-by: Swathi K S <swathi.ks@xxxxxxxxxxx> > Signed-off-by: Sriranjani P <sriranjani.p@xxxxxxxxxxx> > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 5 +- > .../devicetree/bindings/net/tesla,ethqos.yaml | 114 ++++++++++++++++++ > 2 files changed, 117 insertions(+), 2 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/tesla,ethqos.yaml > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index ddf9522a5dc2..0ced7901e644 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -96,6 +96,7 @@ properties: > - snps,dwxgmac > - snps,dwxgmac-2.10 > - starfive,jh7110-dwmac > + - tesla,fsd-ethqos-4.21 I don't think one given SoC - and I was told FSD is strictly defined one specific SoC - can have different versions of the same block, so drop the block versioning. > > reg: > minItems: 1 > @@ -117,7 +118,7 @@ properties: > > clocks: > minItems: 1 > - maxItems: 8 > + maxItems: 10 > additionalItems: true > items: > - description: GMAC main clock > @@ -129,7 +130,7 @@ properties: > > clock-names: > minItems: 1 > - maxItems: 8 > + maxItems: 10 > additionalItems: true > contains: > enum: > diff --git a/Documentation/devicetree/bindings/net/tesla,ethqos.yaml b/Documentation/devicetree/bindings/net/tesla,ethqos.yaml > new file mode 100644 > index 000000000000..b78829246364 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/tesla,ethqos.yaml > @@ -0,0 +1,114 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/tesla,ethqos.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: FSD Ethernet Quality of Service > + > +maintainers: > + - Sriranjani P <sriranjani.p@xxxxxxxxxxx> > + - Swathi K S <swathi.ks@xxxxxxxxxxx> > + > +description: > + dwmmac based tesla ethernet devices which support Gigabit > + ethernet. > + > +allOf: > + - $ref: snps,dwmac.yaml# > + > +properties: > + compatible: > + const: tesla,fsd-ethqos-4.21.yaml ? > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + minItems: 5 Why? I expect it to be specific. > + maxItems: 10 > + > + clock-names: > + minItems: 5 > + maxItems: 10 > + items: > + - const: ptp_ref > + - const: master_bus > + - const: slave_bus > + - const: tx > + - const: rx > + - const: master2_bus > + - const: slave2_bus > + - const: eqos_rxclk_mux > + - const: eqos_phyrxclk > + - const: dout_peric_rgmii_clk > + > + fsd-rx-clock-skew: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + - items: > + - description: phandle to the syscon node > + - description: offset of the control register > + description: > + Should be phandle/offset pair. The phandle to the syscon node. > + > + iommus: > + maxItems: 1 > + > + phy-mode: > + $ref: ethernet-controller.yaml#/properties/phy-connection-type > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - rx-clock-skew Eee? Isn't it fsd-rx-clock-skew which anyway is not correct? > + - iommus > + - phy-mode > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/fsd-clk.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + ethernet_1: ethernet@14300000 { > + compatible = "tesla,dwc-qos-ethernet-4.21"; Three different compatibles for the same. No, please test your patches before sending. I am not even checking if previous feedback was applied... Did you really go through it? Best regards, Krzysztof
