On 23:05-20230811, Kumar, Udit wrote:
> Hi Apurva
>
> On 8/11/2023 8:46 PM, Apurva Nandan wrote:
> > bootph-all as phase tag was added to dt-schema
> > (dtschema/schemas/bootph.yaml) to cover U-Boot challenges with DT.
> > That's why add it also to Linux to be aligned with bootloader requirement.
> >
> > wkup_uart0, wkup_i2c0, mcu_uart0, main_uart8, main_sdhci0 and main_sdhci1
> > are required for bootloader operation on TI K3 AM69-SK EVM. These IPs
> > along with pinmuxes need to be marked for all bootloader phases, hence add
> > bootph-all to these nodes in kernel dts.
> >
> > Signed-off-by: Apurva Nandan <a-nandan@xxxxxx>
> > ---
> > [...]
> > &wkup_uart0 {
> > + bootph-all;
> > /* Firmware usage */
> > status = "reserved";
> > pinctrl-names = "default";
>
> I am not sure, if you want to treat wkup_uart in same way as you are
> treating secure_proxy_mcu in patch 1 of this series.
You should'nt. wkup_uart0 or what ever peripherals are specifically
board dependent. This patch does it the right way. I do have other
platforms on other K3 SoCs where the TIFS uart logs are actually
disabled.
>
> IMO, where we are making this node status is okay, mark booth-all at that
> place only.
>
> Otherwise for rest of series
>
> LGTM
Do i take that as a Reviewed-by: for the series?
>
>
[...]
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
