On Thu, Aug 10, 2023 at 04:21:23AM -0600, Rob Herring wrote: > > On Thu, 10 Aug 2023 15:26:04 +0530, Varadarajan Narayanan wrote: > > Document the M31 USB2 phy present in IPQ5332. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Co-developed-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx> > > Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx> > > Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> > > --- > > v7: > > Move 'compatible' to be the first entry > > In the example have 'usb-phy' instead of 'usb2-phy' > > Add 'Reviewed-by: Krzysztof Kozlowski' > > 'make dt_binding_check DT_SCHEMA_FILES=qcom,ipq5332-usb-hsphy.yaml' passed > > 'make CHECK_DTBS=y DT_SCHEMA_FILES=qcom,ipq5332-usb-hsphy.yaml dtbs_check' passed > > v6: > > Add 'Co-developed-by: Sricharan' > > Add 'const' to compatible, vdd-supply > > Remove label and use usb2-phy for nodename in the example > > v5: > > Add '#phy-cells', to be able to use generic phy > > Remove 'Reviewed-by: Krzysztof Kozlowski' due to above change > > v4: > > Move M31 URL to description > > Remove maxItems and relevant content from clock-names > > Change node name to generic name > > 'make dt_binding_check DT_SCHEMA_FILES=qcom' passed > > v3: > > Incorporate review comments. Will bring in ipq5018 compatible > > string while posting ipq5018 usb patchset. > > > > v1: > > Rename qcom,m31.yaml -> qcom,ipq5332-usb-hsphy.yaml > > Drop default binding "m31,usb-hsphy" > > Add clock > > Remove 'oneOf' from compatible > > Remove 'qscratch' region from register space as it is not needed > > Remove reset-names > > Fix the example definition > > --- > > .../bindings/phy/qcom,ipq5332-usb-hsphy.yaml | 59 ++++++++++++++++++++++ > > 1 file changed, 59 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/0d42f556ab28123b2b508521a0c79c7597b8b0fd.1691660905.git.quic_varada@xxxxxxxxxxx The bot was having an issue. This can be ignored. Rob
