On 00:12-20230811, Apurva Nandan wrote: > bootph-all phase tag was added to dt-schema (dtschema/schemas/bootph.yaml) > to overcome u-boot dts challenges. > > Add bootph-all property for all the nodes that are used in the SPL stage > along with later boot stages. > > This series will be ported to the u-boot k3-j784s4 support patch series > for syncing, and was requested in its review process: > https://lore.kernel.org/u-boot/20230321155227.GV8135@bill-the-cat/ > > v3: Changelog: > 1) Changed all the bootph-pre-ram to bootph-all, as only > secure_proxy_mcu and secure_proxy_sa3 are exclusively used by R5 SPL. > Rest of the nodes are also used by later boot stages. > 2) Merged SoC dtsi changes in single patch. > 3) Moved cbass_main and cbass_mcu_wkup bootph-all to k3-j784s4.dtsi [...] > Apurva Nandan (3): > arm64: dts: ti: k3-j784s4: Add bootph-all property > arm64: dts: ti: k3-j784s4-evm: Add bootph-all property > arm64: dts: ti: k3-am69-sk: Add bootph-all property Follow https://lore.kernel.org/all/48b554aef75d11e6ad2ef7d21f22accb35432112.1683034376.git.michal.simek@xxxxxxx/ for example of proper commit message and subject line. The patch content actually is easy to read since it is adding bootph-all property - but we do have a few exceptions. Commit message should explain the rational of the choices made. For example, you probably need to use secure_proxy_sa3 to talk with tifs in-order to boot and that is a pre-ram property and so on.. So, nice refresh in the right direction, but a bit more work to do. Thanks for handling am69-sk :).. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
