On 09/08/2023 20:44, Alexander Stein wrote: > Hi, > > Am Mittwoch, 9. August 2023, 15:02:23 CEST schrieb Krzysztof Kozlowski: >> On 09/08/2023 08:58, Jerome Brunet wrote: >>>>> + required: >>>>> + - '#reset-cells' >>>> >>>> else: >>>> properties: >>>> '#reset-cells': false >>>> ??? >>>> >>>> >>>> You need to constrain the clocks per variant. Probably names are also >>>> specific to each one, so the list of names can be moved here and you >>>> keep just min/maxItems in the top level property. >>>> >>> >>> input clock names and constraints are the same for all 3 variants. >> >> Then why do you have this huge, apparently unnecessary, oneOf? If it's >> the same, then drop the oneOf and make number of clocks fixed. > > But as far as I understand the number of clocks is not fixed. As Jerome pointed > out in the other post, it can have any combination of clocks and range from 1 > up to 11, where 'pclk' is always 1st clock. > I currently have no idea how to constraint that, despite limiting the number > of clock-names. The same as in all other clock controllers (was also present on my list of useful patterns - Variable length arrays (per variant)): https://elixir.bootlin.com/linux/v5.19-rc6/source/Documentation/devicetree/bindings/clock/samsung,exynos7-clock.yaml#L57 Best regards, Krzysztof
