On Monday 15 December 2014 22:25:21 Suman Tripathi wrote: > + return 0; > +} > + > +static struct of_device_id xgene_ahbc_mmu_of_match[] = { > + { .compatible = "apm,xgene-ahbc-iommu"}, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, xgene_ahbc_mmu_of_match); > + > +static struct platform_driver xgene_ahbc_mmu_driver = { > + .probe = xgene_ahbc_mmu_probe, > + .remove = xgene_ahbc_mmu_remove, > + .driver = { > + .owner = THIS_MODULE, > + .name = "xgene-ahbc", > + .of_match_table = of_match_ptr(xgene_ahbc_mmu_of_match), > + }, > +}; > + > +static int xgene_ahbc_mmu_init(void) > +{ > + return platform_driver_register(&xgene_ahbc_mmu_driver); > +} > +subsys_initcall(xgene_ahbc_mmu_init); > + > +static void __exit xgene_ahbc_mmu_exit(void) > +{ > + platform_driver_unregister(&xgene_ahbc_mmu_driver); > +} > +module_exit(xgene_ahbc_mmu_exit); > This should use the newly added of_iommu infrastructure that we added for 3.19. Otherwise you are just duplicating common code. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html