On Tue, Aug 8, 2023, at 16:42, Ulf Hansson wrote: > On Thu, 3 Aug 2023 at 09:03, Arnd Bergmann <arnd@xxxxxxxx> wrote: >> >> On Thu, Aug 3, 2023, at 08:37, Yinbo Zhu wrote: >> > The Loongson-2's power management controller was ACPI, supports ACPI >> > S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To >> > Disk), ACPI S5 (Soft Shutdown) and supports multiple wake-up methods >> > (USB, GMAC, PWRBTN, etc.). This driver was to add power management >> > controller support that base on dts for Loongson-2 series SoCs. >> > >> > Co-developed-by: Liu Yun <liuyun@xxxxxxxxxxx> >> > Signed-off-by: Liu Yun <liuyun@xxxxxxxxxxx> >> > Co-developed-by: Liu Peibao <liupeibao@xxxxxxxxxxx> >> > Signed-off-by: Liu Peibao <liupeibao@xxxxxxxxxxx> >> > Cc: soc@xxxxxxxxxx >> > Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx> >> > Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> >> >> I'm still waiting for Ulf to take a look here to see whether >> this should be in drivers/genpd instead, but he might still >> be on vacation. > > I don't think this belongs in drivers/genpd/ as it's not a genpd > provider. Besides that, no further comments from me at this point. Ok, thanks! Let's try to finish discussing the suspend-address question and merge it through the soc tree once that is resolved then. Arnd